Leave Previously Seen out of the mail help bar - #411
Merged
Conversation
The tab is already on screen with its number on it, so the help bar was spending a slot to repeat what the nav row says. The key still works and the docs still describe it. The test that pinned the binding was there to tell the list's help from the seen screen's, and there is no longer a difference to tell. What it checked that still matters — the seen screen offering the same thread actions the box list does — stays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops
9 previously seenfrom the mail list's help bar.The tab is already on screen with its number on it, so the help bar was spending a slot to repeat what the nav row says. The key still works and
docs/tui.mdstill describes it — this is the shortcut bar only.The test that pinned the binding existed to tell the list's help from the seen screen's, and with the binding gone there is no difference left to tell. What it checked that still matters — that the seen screen offers the same thread actions the box list does — stays, under a name that says so.
make checkpasses.