Skip to content

fix: Fix failing train tests for v3 #5814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohamedzeidan2021 merged 5 commits into from
May 1, 2026
+2 −1
Merged

fix: Fix failing train tests for v3 #5814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a182f2f
fix: Fix failing train tests for v3
Apr 30, 2026
dc4eff3
serial
Apr 30, 2026
eb3473f
Merge branch 'master' into master
mohamedzeidan2021 Apr 30, 2026
c9743cf
only keep instance type fix
Apr 30, 2026
9de4f23
added serial back since it worked
Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sagemaker-train/tests/integ/jumpstart/test_jumpstart_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
# Override default instance type; the model's default
# (ml.p3.2xlarge) is deprecated.
"compute": Compute(instance_type="ml.g5.xlarge"),
"compute": Compute(instance_type="ml.g4dn.xlarge"),
},
{"model_id": "xgboost-classification-model"},
{"model_id": "catboost-regression-model"},
Expand Down
1 change: 1 addition & 0 deletions sagemaker-train/tests/integ/train/test_llm_as_judge_base_model_fix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
}


@pytest.mark.serial
Copy link
Copy Markdown
Collaborator

@mujtaba1747 mujtaba1747 May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this test passes if run serially, this means there maybe a race condition. We can fix it later post-release.

class TestLLMAsJudgeBaseModelFix:
"""Integration test for base model fix in LLMAsJudgeEvaluator"""

Expand Down
Loading