fix: Fix failing train tests for v3#5814
Merged
mohamedzeidan2021 merged 5 commits intoaws:masterfrom May 1, 2026
Merged
Conversation
mujtaba1747
previously approved these changes
May 1, 2026
| } | ||
|
|
||
|
|
||
| @pytest.mark.serial |
Collaborator
There was a problem hiding this comment.
If this test passes if run serially, this means there maybe a race condition. We can fix it later post-release.
Collaborator
Author
Contributor
|
Found the successful run: https://github.com/aws/sagemaker-python-sdk/actions/runs/25191463012 |
mollyheamazon
approved these changes
May 1, 2026
aviruthen
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix instance type for JumpStart training integration test
test_jumpstart_train[huggingface-spc-bert-base-cased] was failing with ValueError: Training is not supported for model ID with instance type: ml.g5.xlarge. The model's SupportedTrainingInstanceTypes only includes ml.g4dn.* and ml.p3.* variants. Replaced ml.g5.xlarge with ml.g4dn.xlarge.
Note on test_base_model_false_still_works failure:
The other failing test (TestLLMAsJudgeBaseModelFix::test_base_model_false_still_works) is a pre-existing flaky test unrelated to both this change and the release commits. None of the release changes touch the evaluation pipeline code path:
"Make _PipelineExecution a public class" affects the pipeline execution class visibility, not the evaluation pipeline template rendering or _get_or_create_pipeline logic.
"Add CodeArtifact support for ModelTrainer" and "Wire FrameworkProcessor code_location" affect training source code/dependency installation, not the evaluator module.
The S3 bucket/path fixes are in core S3 utilities, not in the evaluation pipeline template selection.
The git_utils and service-2.json changes are unrelated to evaluation.
The test fails due to a race condition in the test itself: pytest-xdist runs test_base_model_evaluation_uses_correct_weights (evaluate_base_model=True) and test_base_model_false_still_works (evaluate_base_model=False) in parallel. Both call _get_or_create_pipeline with the same pipeline name prefix, so one test's pipeline.update() overwrites the other's pipeline definition before execution starts. This is a shared-resource concurrency issue in the test infrastructure that predates these release changes. A separate fix (e.g., marking the class @pytest.mark.serial) is needed to address it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.