Skip to content

ADFA-2522: Run spotlessCheck in CI for pull requests #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-ADFA wants to merge 1 commit into
base: stage
Choose a base branch
from
+7 −0
Open

ADFA-2522: Run spotlessCheck in CI for pull requests #1512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/debug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,13 @@ jobs:
flox activate -d flox/base -- ./gradlew :app:assembleV8Debug --no-daemon
echo "gradle_time_end=$(date +%s)" >> $GITHUB_ENV
- name: Run spotlessCheck

@dara-abijo-adfa dara-abijo-adfa Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have a suggestion - Could we move the step to run before the Assemble Universal APK step to help the CI fail fast?

run: |
flox activate -d flox/base -- ./gradlew spotlessCheck --no-daemon || {
echo "::error::Spotless found formatting violations in this branch. Run './gradlew spotlessApply' locally, then commit and push the formatted files."
exit 1
}
- name: Find APK file
id: find_apk
run: |
Expand Down
Loading