Skip to content

ADFA-2522: Run spotlessCheck in CI for pull requests#1512

Open
Daniel-ADFA wants to merge 1 commit into
stagefrom
ADFA-2522
Open

ADFA-2522: Run spotlessCheck in CI for pull requests#1512
Daniel-ADFA wants to merge 1 commit into
stagefrom
ADFA-2522

Conversation

@Daniel-ADFA

@Daniel-ADFA Daniel-ADFA commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
  • Add a Run spotlessCheck step to the build_apk job in debug.yml, immediately after the APK is assembled

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@Daniel-ADFA Daniel-ADFA requested review from a team and itsaky-adfa July 13, 2026 12:22
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c1b4a746-f2b4-472b-b79b-f295c97424ba

📥 Commits

Reviewing files that changed from the base of the PR and between b755cfd and 81669f0.

📒 Files selected for processing (1)
  • .github/workflows/debug.yml

📝 Walkthrough
  • Added a read-only spotlessCheck step to the build_apk workflow after APK assembly.
  • Formatting violations now fail CI with guidance to run ./gradlew spotlessApply.
  • Checks only changes relative to origin/stage, matching local hook behavior.
  • Risk: PRs may be blocked by formatting issues when local hooks are unavailable or bypassed.

Walkthrough

The Android APK debug workflow now runs spotlessCheck before subsequent build and deployment steps, reporting formatting violations and failing the job when they are found.

Changes

APK Formatting Verification

Layer / File(s) Summary
Add APK formatting gate
.github/workflows/debug.yml
The workflow runs ./gradlew spotlessCheck under flox activate and exits with an error when formatting violations are detected.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a bunny with tidy ears,
Formatting checked before builds appear.
Spotless hops through every line,
Errors thump when things aren’t fine.
Then APKs safely cross the gate.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding spotlessCheck to CI for pull requests.
Description check ✅ Passed The description matches the change by describing the new spotlessCheck step in the APK build job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-2522

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

flox activate -d flox/base -- ./gradlew :app:assembleV8Debug --no-daemon
echo "gradle_time_end=$(date +%s)" >> $GITHUB_ENV

- name: Run spotlessCheck

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have a suggestion - Could we move the step to run before the Assemble Universal APK step to help the CI fail fast?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants