Skip to content

ADFA-3678: Remove dead Sonatype OSSRH snapshot version lookup #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-ADFA wants to merge 1 commit into
base: stage
Choose a base branch
from
+1 −51
Open

ADFA-3678: Remove dead Sonatype OSSRH snapshot version lookup #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...ilds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/ProjectConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,6 @@ val Project.downloadVersion: String
return if (CI.isCiBuild || isFDroidBuild) {
publishingVersion
} else {
// sometimes, when working locally, Gradle fails to download the latest snapshot version
// this may cause issues while initializing the project in AndroidIDE
VersionUtils.getLatestSnapshotVersion("gradle-plugin")
VersionUtils.LATEST_INTEGRATION
}
}
46 changes: 0 additions & 46 deletions ...uilds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/VersionUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@

package com.itsaky.androidide.build.config

import org.gradle.api.GradleException
import java.io.BufferedInputStream
import java.net.URI
import javax.xml.parsers.DocumentBuilderFactory
import javax.xml.xpath.XPathFactory

/**
* @author Akash Yadav
*/
Expand All @@ -41,44 +35,4 @@ object VersionUtils {
* The latest integration version name.
*/
const val LATEST_INTEGRATION = "latest.integration"

/**
* The cached version name.
*/
private var cachedVersion: String? = null

/**
* Gets the latest snapshot version of the given artifact from the Sonatype snapshots repository.
*/
@JvmStatic
fun getLatestSnapshotVersion(artifact: String): String {
cachedVersion?.also { cached ->
println("Found latest version of artifact '$artifact' : '$cached' (cached)")
return cached
}

val groupId = BuildConfig.PACKAGE_NAME.replace('.', '/')
val moduleMetadata = "$SONATYPE_SNAPSHOTS_REPO$groupId/$artifact/maven-metadata.xml"
return try {
BufferedInputStream(URI.create(moduleMetadata).toURL().openStream()).use { inputStream ->
val builderFactory = DocumentBuilderFactory.newInstance()
val builder = builderFactory.newDocumentBuilder()
val document = builder.parse(inputStream)

val xPathFactory = XPathFactory.newInstance()
val xPath = xPathFactory.newXPath()

val latestVersion = xPath.evaluate("/metadata/versioning/latest", document)
cachedVersion = latestVersion
println("Found latest version of artifact '$artifact' : '$latestVersion'")
return@use latestVersion
}
} catch (err: Throwable) {
if (CI.isCiBuild) {
throw GradleException("Failed to download: $moduleMetadata", err)
}
println("Failed to download $moduleMetadata: ${err.message}")
return LATEST_INTEGRATION
}
}
}
2 changes: 0 additions & 2 deletions settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ dependencyResolutionManagement {
repositories {
google()
mavenCentral()
maven { url = uri("https://s01.oss.sonatype.org/content/repositories/snapshots/") }
maven { url = uri("https://s01.oss.sonatype.org/content/groups/public/") }
maven { url = uri("https://jitpack.io") }
}
}
Expand Down
Loading