Skip to content

ADFA-3678: Remove dead Sonatype OSSRH snapshot version lookup#1510

Open
Daniel-ADFA wants to merge 1 commit into
stagefrom
ADFA-3678
Open

ADFA-3678: Remove dead Sonatype OSSRH snapshot version lookup#1510
Daniel-ADFA wants to merge 1 commit into
stagefrom
ADFA-3678

Conversation

@Daniel-ADFA

Copy link
Copy Markdown
Contributor

s01.oss.sonatype.org was permanently shut down when Sonatype sunset OSSRH (June 2025), so every local build logged a warning from generateBuildInfo failing to fetch gradle-plugin/maven-metadata.xml before falling back to "latest.integration".

  • Return VersionUtils.LATEST_INTEGRATION directly for local builds in
    Project.downloadVersion; the network lookup could only ever fail
  • Delete the unused getLatestSnapshotVersion() and its version cache
  • Drop both dead s01.oss.sonatype.org repos from settings.gradle.kts

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c812dbd5-8776-43ec-8ca5-f1328a3e8be8

📥 Commits

Reviewing files that changed from the base of the PR and between 5c9cfc2 and 0dfccda.

📒 Files selected for processing (2)
  • composite-builds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/ProjectConfig.kt
  • composite-builds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/VersionUtils.kt
💤 Files with no reviewable changes (1)
  • composite-builds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/VersionUtils.kt
🚧 Files skipped from review as they are similar to previous changes (1)
  • composite-builds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/ProjectConfig.kt

📝 Walkthrough
  • Removed obsolete Sonatype OSSRH snapshot lookup and related network/XML parsing, caching, and error handling.
  • Local builds now use VersionUtils.LATEST_INTEGRATION directly.
  • Removed inactive Sonatype repositories from Gradle settings.
  • Added the :profiler module to the included project list.
  • Risk: removing snapshot resolution may affect workflows that relied on dynamically discovering published integration versions.

Walkthrough

The build configuration now uses a fixed integration version for local builds, removes snapshot metadata lookup and related repositories, and registers the :profiler Gradle module.

Changes

Build version resolution

Layer / File(s) Summary
Replace snapshot lookup with fixed version
composite-builds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/ProjectConfig.kt, composite-builds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/VersionUtils.kt, settings.gradle.kts
Local builds return LATEST_INTEGRATION; snapshot metadata downloading, parsing, caching, and related Sonatype repositories are removed.

Profiler module setup

Layer / File(s) Summary
Register profiler module
settings.gradle.kts
The Gradle project include list adds :profiler.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a rabbit hopping through builds,
With snapshots tucked away,
A profiler joins the project list,
While constants lead the way.
Hop, compile, and spring!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing the obsolete Sonatype OSSRH snapshot lookup.
Description check ✅ Passed The description matches the changeset and summarizes the local-build lookup removal and repository cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-3678

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Daniel-ADFA Daniel-ADFA requested a review from a team July 12, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants