Skip to content

Fix Linkis ticket cipher rollback tests #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Linkis ticket cipher rollback tests #5491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb8077
test(linkis-module): configure synthetic crypt key for unit tests
dajiaohuang Oct 26, 2026
0af183f
fix(linkis-common): decrypt v2 tickets when v2 issuance is disabled
dajiaohuang Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/utils/TicketCipher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public class TicketCipher {
"linkis-ticket-v2".getBytes(StandardCharsets.UTF_8);
private static final byte VERSION_V2 = 0x02;

private final boolean useV2;
private final SecretKey encKey;
private final String cryptKeyRaw;
private final SecureRandom rng = new SecureRandom();
Expand All @@ -68,14 +69,11 @@ public class TicketCipher {
*/
public TicketCipher(String cryptKeyRaw, boolean useV2) {
this.cryptKeyRaw = cryptKeyRaw;
if (useV2) {
try {
this.encKey = deriveKey(cryptKeyRaw);
} catch (Exception e) {
throw new RuntimeException("Failed to derive ticket encryption key", e);
}
} else {
this.encKey = null; // unused in V1 mode
this.useV2 = useV2;
try {
this.encKey = deriveKey(cryptKeyRaw);
} catch (Exception e) {
throw new RuntimeException("Failed to derive ticket encryption key", e);
}
}

Expand All @@ -86,7 +84,7 @@ public TicketCipher(String cryptKeyRaw, boolean useV2) {
* When V2 is disabled: legacy DES (via DESUtil.encrypt).
*/
public String encrypt(String plaintext) throws Exception {
if (encKey != null) {
if (useV2) {
return encryptV2(plaintext);
}
return DESUtil.encrypt(plaintext, cryptKeyRaw);
Expand Down
3 changes: 2 additions & 1 deletion linkis-commons/linkis-module/src/test/resources/linkis.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ wds.linkis.server.version=v1

#test
wds.linkis.test.mode=true
wds.linkis.test.user=hadoop
wds.linkis.test.user=hadoop
wds.linkis.crypt.key=linkis-unit-test-crypt-key-not-for-deployment