Repository navigation
Fix Linkis ticket cipher rollback tests - #5491
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Addresses two unit-test failures reported in #5482 after applying the captured #5483 fixes.
TicketCipher.decryptrecognizes V2 envelopes, but a cipher configured to issue legacy V1 tickets has no AES key, so it throwsInvalidKeyExceptioninstead of decrypting existing V2 tickets during rollback. Separately, thelinkis-moduletest properties omit the required crypt key, preventingServerConfigurationTestandSecurityFilterTestfrom initializing.Related issues/PRs
Related issue: #5482 (the remaining unit-test failures; this PR does not claim to resolve the other reported CI issues).
Brief change log
wds.linkis.crypt.keyonly tolinkis-moduletest properties. Production configuration remains unchanged and fail-closed.Validation
b346cd419b08b919e5126913b519228b86213c4bplus these changes: focused Maven run forClassUtilsTest,TicketCipherTest,ServerConfigurationTest, andSecurityFilterTestpassed (30 tests total).bad400a77b9502a68ec229ce6a5aedab6f039b28still has compilation errors fixed by Fix Scala compilation of linkis-module #5483, so the module tests were run on Fix Scala compilation of linkis-module #5483's captured head.