Skip to content

Adjust buffer sizes to accomodate changes in org.apache.hc.core5.http.config.Http1Config #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reta merged 2 commits into from
Nov 4, 2026
Merged

Adjust buffer sizes to accomodate changes in org.apache.hc.core5.http.config.Http1Config #3676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5cf247
Adjust buffer sizes to accomodate changes in org.apache.hc.core5.http…
reta Nov 4, 2026
58304b3
Address code review comments
reta Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ttp-hc5/src/main/java/org/apache/cxf/transport/http/asyncclient/hc5/AsyncHTTPConduit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ public AsyncWrappedOutputStream(Message message, boolean needToCacheRequest, boo
basicEntity = (MutableHttpEntity)entity.getEntity();
basicEntity.setChunked(isChunking);

final int bufSize = csPolicy.getChunkLength() > 0 ? csPolicy.getChunkLength() : 16320;
final int bufSize = csPolicy.getChunkLength() > 0 ? csPolicy.getChunkLength() : 32 * 1024;
inbuf = new SharedInputBuffer(bufSize);
outbuf = new SharedOutputBuffer(bufSize);
isAsync = outMessage != null && outMessage.getExchange() != null
Expand Down
2 changes: 1 addition & 1 deletion .../src/main/java/org/apache/cxf/transport/http/asyncclient/hc5/AsyncHTTPConduitFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public PoolingAsyncClientConnectionManager getConnectionManager() {
private int soTimeout = IOReactorConfig.DEFAULT.getSoTimeout().toMillisecondsIntBound();
private boolean soKeepalive = IOReactorConfig.DEFAULT.isSoKeepAlive();
private boolean tcpNoDelay = true;
private int bufferSize = 16 * 1024;
private int bufferSize = 32 * 1024; // Http1Config::INIT_BUF_SIZE

AsyncHTTPConduitFactory() {
super();
Expand Down
4 changes: 2 additions & 2 deletions ...ain/java/org/apache/cxf/transport/http/asyncclient/hc5/URLConnectionAsyncHTTPConduit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ public AsyncWrappedOutputStream(Message message, boolean needToCacheRequest, boo
basicEntity = (MutableHttpEntity)entity.getEntity();
basicEntity.setChunked(isChunking);

final int bufSize = csPolicy.getChunkLength() > 0 ? csPolicy.getChunkLength() : 16320;
final int bufSize = csPolicy.getChunkLength() > 0 ? csPolicy.getChunkLength() : 32 * 1024;
inbuf = new SharedInputBuffer(bufSize);
outbuf = new SharedOutputBuffer(bufSize);
isAsync = outMessage != null && outMessage.getExchange() != null
Expand Down Expand Up @@ -885,7 +885,7 @@ protected void setupNewConnection(String newURL) throws IOException {
sslURL = null;

//reset the buffers
int bufSize = csPolicy.getChunkLength() > 0 ? csPolicy.getChunkLength() : 16320;
int bufSize = csPolicy.getChunkLength() > 0 ? csPolicy.getChunkLength() : 32 * 1024;
inbuf = new SharedInputBuffer(bufSize);
outbuf = new SharedOutputBuffer(bufSize);
try {
Expand Down
Loading