Skip to content

Adjust buffer sizes to accomodate changes in org.apache.hc.core5.http.config.Http1Config - #3676

Merged
reta merged 2 commits into
apache:mainfrom
reta:adjust.buffer.sizes
Nov 4, 2026
Merged

reta merged 2 commits into
apache:mainfrom
reta:adjust.buffer.sizes

Conversation

@reta

@reta reta commented Nov 4, 2026

Copy link
Copy Markdown
Member

Adjust buffer sizes to accomodate changes in org.apache.hc.core5.http.config.Http1Config

@reta
reta requested a review from ffang November 4, 2026 02:13
@ffang

ffang commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thanks @reta, LGTM. Going back to the httpcore5 default (Http1Config.INIT_BUF_SIZE is 32768 in 5.4.4) makes sense now that the SharedInputBuffer deadlock is fixed (CXF-9268), and using 32 KiB for the conduit buffers when chunkLength isn't set matches the size already used when the request is re-sent. The hc5 tests and the async transport systests pass, and so does the reporter's test from CXF-9268 with the new defaults.

One small thing:

  • URLConnectionAsyncHTTPConduit still uses 16320 in both places (lines 313 and 888), while it gets the same 32 KiB HTTP/1.1 blocks from the factory. Could it be changed the same way, for consistency?

Thanks!
Freeman

@reta

reta commented Nov 4, 2026

Copy link
Copy Markdown
Member Author
  • URLConnectionAsyncHTTPConduit still uses 16320 in both places (lines 313 and 888), while it gets the same 32 KiB HTTP/1.1 blocks from the factory. Could it be changed the same way, for consistency?

Thanks @ffang , makes sense, done!

@reta
reta merged commit 9eeb9f8 into apache:main Nov 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants