Repository navigation
chore: [Remote rendering] Clean up renderer interface before adding a second mode - #176
Open
LKasianAnsys wants to merge 6 commits into
Open
LKasianAnsys wants to merge 6 commits into
LKasianAnsys wants to merge 6 commits into
Conversation
LKasianAnsys
changed the base branch from
main
to
chore/3.6d-deliver-without-sending
October 15, 2026 22:42
LKasianAnsys
force-pushed
the
chore/3.6d-deliver-without-sending
branch
from
October 16, 2026 17:05
227af31 to
029d796
Compare
LKasianAnsys
force-pushed
the
chore/renderer-interface-cleanup
branch
from
October 16, 2026 17:05
d84997b to
34307fd
Compare
LKasianAnsys
force-pushed
the
chore/3.6d-deliver-without-sending
branch
from
October 16, 2026 17:38
029d796 to
3140dee
Compare
LKasianAnsys
force-pushed
the
chore/renderer-interface-cleanup
branch
from
October 16, 2026 17:40
bea3b90 to
441d124
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #26
Until now, the renderer interfaces on both the server and the client had only ever had one real implementation. They've picked up code that only really belong to the vtk-wasm implmentation, and there's also some dead code that should be removed before building on it.
The server interface carried wasm-specific members, and each implementation kept its own copy of the camera and cross-section plane records. The browser interface had
attachSceneGraph, which only had one live call that was no longer needed. Anything not needed here by a remote rendering implementation would need to be implemented as a no-op, so removing here now.This PR:
attachSceneGraphManual check: