Skip to content

chore: [Remote rendering] Clean up renderer interface before adding a second mode - #176

Open
LKasianAnsys wants to merge 6 commits into
chore/3.6d-deliver-without-sendingfrom
chore/renderer-interface-cleanup
Open

LKasianAnsys wants to merge 6 commits into
chore/3.6d-deliver-without-sendingfrom
chore/renderer-interface-cleanup

Conversation

@LKasianAnsys

Copy link
Copy Markdown
Collaborator

Addresses #26

Until now, the renderer interfaces on both the server and the client had only ever had one real implementation. They've picked up code that only really belong to the vtk-wasm implmentation, and there's also some dead code that should be removed before building on it.

The server interface carried wasm-specific members, and each implementation kept its own copy of the camera and cross-section plane records. The browser interface had attachSceneGraph, which only had one live call that was no longer needed. Anything not needed here by a remote rendering implementation would need to be implemented as a no-op, so removing here now.

This PR:

  • Removes unused members on both stacks
  • Moves wasm-only members off the server interface onto the local renderer, which the local scene references directly
  • Keeps the camera and cross-section plane records on the server-side renderer base instead of on the implementations
  • Removes attachSceneGraph
  • Moves full screen off the renderer, since it only touches the page, and renames the frontend's global edges method to match the renderer's.

Manual check:

  • Load a scene with a multiblock dataset. Color a part by a variable; no errors on the server or console are logged.
  • Click the wire frame widget: every part shows a wire frame. Clicking it again turns it off for every part.
  • Toggle the bounding box on and off; it works as expected.
  • Turn full screen on, then off; works as expected.
  • Run save_state, change something in the scene, then load the file back in. The parts, camera and panels restore correctly.
  • No browser console errors throughout

@github-actions github-actions Bot added test Work associated with testing miscellaneous labels Oct 15, 2026
@LKasianAnsys
LKasianAnsys changed the base branch from main to chore/3.6d-deliver-without-sending October 15, 2026 22:42
@LKasianAnsys
LKasianAnsys force-pushed the chore/3.6d-deliver-without-sending branch from 227af31 to 029d796 Compare October 16, 2026 17:05
@LKasianAnsys
LKasianAnsys force-pushed the chore/renderer-interface-cleanup branch from d84997b to 34307fd Compare October 16, 2026 17:05
@LKasianAnsys
LKasianAnsys force-pushed the chore/3.6d-deliver-without-sending branch from 029d796 to 3140dee Compare October 16, 2026 17:38
@LKasianAnsys
LKasianAnsys force-pushed the chore/renderer-interface-cleanup branch from bea3b90 to 441d124 Compare October 16, 2026 17:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

miscellaneous test Work associated with testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants