remove unused client renderer members

Author: LKasianAnsys

src/ansys/visor/visor-client/src/VisorFrontend.tsx

@@ -14,6 +14,7 @@ import { attachCameraSyncReporter } from './CameraSyncReporter';
 import { Panel_TopRight_Util } from './components/ui-panels/Panel_TopRight_Util.tsx';
 import { Panel_TopLeft_Util } from './components/ui-panels/Panel_TopLeft_Util.tsx';
 import { OrientationWidget } from './widgets/orientationWidget.ts';
+import { FullscreenWidget } from './widgets/fullscreenWidget.ts';
 import { UiScaffoldUtil } from './components/UiScaffold.tsx';
 
 export type { VisorCameraState } from './renderer/IRenderer';
@@ -255,8 +256,10 @@ export class VisorFrontend {
             sendUiPanelTriggerAsync('set_panel_top_right_legend_collapsed', { collapsed });
         this.sendPanelTopRightTabIndexAsync = (tabIndex) =>
             sendUiPanelTriggerAsync('set_panel_top_right_tab_index', { tabIndex });
-        this.toggleFullScreenAsync = () => renderer.toggleFullScreenAsync();
-        this.setEdgeVisibilityAsync = (visible) => renderer.setEdgeVisibilityGlobalAsync(visible);
+        const fullscreenWidget = new FullscreenWidget();
+        this.toggleFullScreenAsync = () => fullscreenWidget.setFullScreenAsync();
+        this.setEdgeVisibilityGlobalAsync = (visible) =>
+            renderer.setEdgeVisibilityGlobalAsync(visible);
         this.setCrossSectionVisibilityAsync = (visible) =>
             renderer.setCrossSectionVisibilityAsync(visible);
         this.setBoundingBoxVisibilityAsync = (visible) =>
@@ -578,7 +581,8 @@ export class VisorFrontend {
     addFrameRenderedListener: (handler: (fps: number) => void) => () => void;
     setCrossSectionVisibilityAsync: (visible?: boolean) => Promise<void>;
     setBoundingBoxVisibilityAsync: (visible?: boolean) => Promise<void>;
-    setEdgeVisibilityAsync: (visible?: boolean | undefined) => Promise<void>;
+    /** Show, hide or toggle edges on every part. */
+    setEdgeVisibilityGlobalAsync: (visible?: boolean | undefined) => Promise<void>;
     setOrthographicModeAsync: (enable?: boolean) => Promise<void>;
     getAppStateAsync: (keyedByName?: boolean) => Promise<VisorAppState>;
     setAppStateAsync: (state?: StateInput<VisorAppState>, updateUI?: boolean) => Promise<void>;

src/ansys/visor/visor-client/src/components/ui-panels/Panel_BottomMiddle.tsx

@@ -62,7 +62,7 @@ export const Panel_BottomMiddle: FC<{
             await visorState.render();
         };
         wireFrameCell.onclick = async () => {
-            await visorState.setEdgeVisibilityAsync();
+            await visorState.setEdgeVisibilityGlobalAsync();
             await visorState.render();
         };
         getFullScreenCell.onclick = async () => {

src/ansys/visor/visor-client/src/renderer/IRenderer.ts

@@ -23,17 +23,6 @@ export type VisorCameraState = Readonly<{
     parallelScale: number;
 }>;
 
-/** The seven camera fields that can be applied. No derived fields. */
-export type AppliedCameraState = Readonly<{
-    position: readonly number[];
-    focalPoint: readonly number[];
-    viewUp: readonly number[];
-    clippingRange: readonly number[];
-    parallelProjection: boolean;
-    viewAngle: number;
-    parallelScale: number;
-}>;
-
 /**
  * Where a settled camera change came from: `gesture` if user input was
  * active during the change, `programmatic` otherwise.
@@ -104,14 +93,6 @@ export interface IRenderer {
     setCameraParallelProjectionAsync(enabled: boolean): Promise<void>;
     setCameraViewAngleAsync(angle: number): Promise<void>;
     setCameraParallelScaleAsync(scale: number): Promise<void>;
-    /**
-     * Apply the seven applied camera fields in one RPC. WasmRenderer implements it
-     * by delegating to the seven per-field setters above. See §11 for the
-     * Story 3.2 rationale (server-tracked camera + sync-back).
-     */
-    setCameraStateAsync(state: AppliedCameraState): Promise<void>;
-    /** Frame the scene on the given bounds; used by scene-graph rebuilds. */
-    resetCameraAsync(bounds?: readonly number[]): Promise<void>;
 
     // ---- Subscriptions (return unsubscribe closures) ------------------------
     /** Fires whenever the camera changes. Callback receives a full snapshot. */
@@ -243,8 +224,6 @@ export interface IRenderer {
     /** Whether edges are shown on every part in the scene. See contract note above. */
     areEdgesVisibleGlobally(): boolean;
 
-    toggleFullScreenAsync(): Promise<void>;
-
     // ---- Picking (geometry pick — the vertex/edge/face path) ---------------
     /**
      * Perform a geometry pick at the given viewport-normalised coordinates.

src/ansys/visor/visor-client/src/renderer/NullRenderer.ts

@@ -1,5 +1,4 @@
 import {
-    AppliedCameraState,
     CameraOrigin,
     ColorVariableDescriptor,
     GeometryPickMode,
@@ -25,9 +24,7 @@ const NULL_CAMERA_STATE: VisorCameraState = {
 };
 
 /**
- * No-op implementation of IRenderer. Used to confirm the interface is
- * buildable and to serve as a placeholder renderer until a concrete one is
- * wired in. Nothing imports this yet.
+ * No-op renderer for tests that need an `IRenderer` with no wasm behind it.
  */
 export class NullRenderer implements IRenderer {
     readonly domElement: HTMLDivElement = document.createElement('div');
@@ -76,14 +73,6 @@ export class NullRenderer implements IRenderer {
         // no-op
     }
 
-    async setCameraStateAsync(_state: AppliedCameraState): Promise<void> {
-        // no-op
-    }
-
-    async resetCameraAsync(_bounds?: readonly number[]): Promise<void> {
-        // no-op
-    }
-
     addCameraChangedListener(_callback: (state: VisorCameraState) => void): () => void {
         return () => {
             // no-op unsubscribe
@@ -264,10 +253,6 @@ export class NullRenderer implements IRenderer {
         // no-op
     }
 
-    async toggleFullScreenAsync(): Promise<void> {
-        // no-op
-    }
-
     async pickGeometryAsync(
         _normX: number,
         _normY: number,

src/ansys/visor/visor-client/src/renderer/WasmRenderer.ts

@@ -1,5 +1,4 @@
 import {
-    AppliedCameraState,
     CameraOrigin,
     ColorVariableDescriptor,
     GeometryPickMode,
@@ -14,7 +13,6 @@ import { WasmNodeHandles, WasmRendererAnnotation } from './RendererAnnotation';
 import { CrossSectionWidget } from '../widgets/crossSectionWidget.ts';
 import { BoundingBoxWidget } from '../widgets/boundingBoxWidget.ts';
 import { OrthographicWidget } from '../widgets/orthographicWidget.ts';
-import { FullscreenWidget } from '../widgets/fullscreenWidget.ts';
 import { EdgesWidget } from '../widgets/edgesWidget.ts';
 
 const SELECTION_TINT_RGB: Readonly<number[]> = [0 / 255, 62 / 255, 111 / 255];
@@ -54,7 +52,6 @@ export class WasmRenderer implements IRenderer {
             widgetWasmId: wasmPlaneWidgetId,
         });
         this.#orthographicWidget = new OrthographicWidget(vtkScene);
-        this.#fullscreenWidget = new FullscreenWidget();
         this.#boundingBoxWidget = new BoundingBoxWidget(vtkScene, {
             outlineActorId: annotation.widgets.boundingBoxOutlineActorId,
             axesActorId: annotation.widgets.boundingBoxAxesActorId,
@@ -151,7 +148,6 @@ export class WasmRenderer implements IRenderer {
     readonly #nodeIdToHandles = new Map<NodeId, WasmNodeHandles>();
     readonly #crossSectionWidget: CrossSectionWidget;
     readonly #orthographicWidget: OrthographicWidget;
-    readonly #fullscreenWidget: FullscreenWidget;
     readonly #boundingBoxWidget: BoundingBoxWidget;
     readonly #edgesWidget: EdgesWidget;
 
@@ -222,26 +218,6 @@ export class WasmRenderer implements IRenderer {
         await this.#vtkScene.camera.setParallelScale(scale);
     }
 
-    async setCameraStateAsync(state: AppliedCameraState): Promise<void> {
-        // Sequential, not Promise.all, to preserve the observable ordering of
-        // camera events any FPS/camera-changed listener sees (§11).
-        await this.setCameraPositionAsync(state.position);
-        await this.setCameraFocalPointAsync(state.focalPoint);
-        await this.setCameraViewUpAsync(state.viewUp);
-        await this.setCameraClippingRangeAsync(state.clippingRange);
-        await this.setCameraParallelProjectionAsync(state.parallelProjection);
-        await this.setCameraViewAngleAsync(state.viewAngle);
-        await this.setCameraParallelScaleAsync(state.parallelScale);
-    }
-
-    async resetCameraAsync(bounds?: readonly number[]): Promise<void> {
-        if (bounds != null) {
-            await this.#vtkScene.renderer.ResetCamera(bounds);
-        } else {
-            await this.#vtkScene.renderer.ResetCamera();
-        }
-    }
-
     // ---- Subscriptions ----------------------------------------------------
     addCameraChangedListener(callback: (state: VisorCameraState) => void): () => void {
         return this.#vtkScene.addCameraChangedListener(async (_) => {
@@ -609,10 +585,6 @@ export class WasmRenderer implements IRenderer {
         await this.#edgesWidget.setEdgesVisibleAsync(visible);
     }
 
-    async toggleFullScreenAsync(): Promise<void> {
-        await this.#fullscreenWidget.setFullScreenAsync();
-    }
-
     // ---- Picking ------------------------------------------------------------
     async pickGeometryAsync(
         normX: number,