Skip to content

build: update jasmine dependencies to v7 #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angular-robot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: update jasmine dependencies to v7 #3922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/integration/tests/angular-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@types/jasmine": "~6.0.0",
"@types/node": "24.13.3",
"chromedriver": "^151.0.0",
"jasmine-core": "6.3.0",
"jasmine-core": "7.0.1",

@gemini-code-assist gemini-code-assist Bot Aug 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The major version of jasmine-core is updated to 7.0.1, but @types/jasmine remains at ~6.0.0 (line 28). This major version mismatch can lead to TypeScript compilation errors or missing type definitions for Jasmine v7 features. Update @types/jasmine to ~7.0.0 to match the new major version of Jasmine.

"karma": "~6.4.4",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.1",
Expand Down
16 changes: 8 additions & 8 deletions bazel/integration/tests/angular-cli/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bazel/rules/rules_browsers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@web/test-runner-core": "^1.0.0",
"@web/test-runner-puppeteer": "^1.0.0",
"get-port": "^7.1.0",
"jasmine": "^6.0.0",
"jasmine": "^7.0.0",
"protractor": "^7.0.0",
"tinyglobby": "^0.2.12",
"typescript": "6.0.3",
Expand Down
25 changes: 15 additions & 10 deletions bazel/rules/rules_browsers/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bazel/spec-bundling/test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"@types/jsdom": "30.0.0",
"@types/node": "24.13.3",
"jasmine-reporters": "2.5.2",
"jasmine": "6.3.0",
"jasmine": "7.0.0",
"jsdom": "30.0.1",
"tinyglobby": "0.2.17",
"zone.js": "0.16.2"
Expand Down
2 changes: 1 addition & 1 deletion github-actions/labeling/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
"micromatch": "^4.0.8",
"typed-graphqlify": "3.1.6",
"@octokit/openapi-types": "28.0.0",
"jasmine": "6.3.0"
"jasmine": "7.0.0"
}
}
4 changes: 2 additions & 2 deletions ng-dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@
"fast-glob": "3.3.3",
"firebase": "12.17.1",
"folder-hash": "4.1.3",
"jasmine-core": "6.3.0",
"jasmine-core": "7.0.1",
"jasmine-reporters": "2.5.2",
"jasmine": "6.3.0",
"jasmine": "7.0.0",
"jsonc-parser": "3.3.1",
"minimatch": "10.2.6",
"multimatch": "8.0.0",
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
"@bazel/buildifier": "8.2.1",
"firebase-tools": "15.26.0",
"husky": "9.1.7",
"jasmine-core": "6.3.0",
"jasmine-core": "7.0.1",
"jasmine-reporters": "2.5.2",
"jasmine": "6.3.0",
"jasmine": "7.0.0",
"prettier": "3.9.6",
"tslib": "^2.5.2",
"tslint": "6.1.3",
Expand Down
46 changes: 23 additions & 23 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading