build: update jasmine dependencies to v7 - #3922
Open
angular-robot wants to merge 1 commit into
Open
Conversation
See associated pull request for more information.
angular-robot
added
action: merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades jasmine and jasmine-core to version 7 across several package files and updates the lockfiles accordingly. A review comment points out that @types/jasmine should also be updated to version 7 to prevent potential TypeScript compilation errors due to major version mismatches.
| "@types/node": "24.13.3", | ||
| "chromedriver": "^151.0.0", | ||
| "jasmine-core": "6.3.0", | ||
| "jasmine-core": "7.0.1", |
There was a problem hiding this comment.
The major version of jasmine-core is updated to 7.0.1, but @types/jasmine remains at ~6.0.0 (line 28). This major version mismatch can lead to TypeScript compilation errors or missing type definitions for Jasmine v7 features. Update @types/jasmine to ~7.0.0 to match the new major version of Jasmine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.3.0→7.0.0^6.0.0→^7.0.06.3.0→7.0.1Release Notes
jasmine/jasmine-npm (jasmine)
v7.0.0Compare Source
Please see the release notes.
jasmine/jasmine (jasmine-core)
v7.0.1Compare Source
Please see the release notes.
v7.0.0Compare Source
Please see the release notes.