fix(core): use Heap::emplace in groupby/bf search - #633
Open
JalinWang wants to merge 2 commits into
Open
Conversation
JalinWang
changed the title
JalinWang
changed the title
JalinWang
marked this pull request as ready for review
July 30, 2026 06:17
egolearner
reviewed
Aug 6, 2026
egolearner
left a comment
egolearner
left a comment
Collaborator
There was a problem hiding this comment.
看下heap能改为private继承吗，否则外部还是容易误用
template <typename T, typename TCompare = std::less<T>,
typename TBase = std::vector<T>>
class Heap : public TBase {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace inherited
std::vector::emplace_backcalls withailego::Heap::emplace.Heap::emplacemaintains heap ordering and enforces capacity limits;emplace_backbypassed both, breaking best-first candidate traversal and allowing group heaps to grow without bound.Also correct DiskANN initial group seeding to insert into the group heap.