fix: asan issues(visit_filter off-by-one and other) - #650
Open
JalinWang wants to merge 3 commits into
Open
Conversation
- visit_filter.h: off-by-one in VisitByteMap bounds check (> → >=) - hnsw/hnsw_rabitq/hnsw_sparse: use emplace() instead of emplace_back() on TopkHeap/CandidateHeap to maintain heap invariant - diskann_builder_entity: brace-init → parentheses-init for vector fill - diskann_util: guard aligned_alloc for size==0 and round up to alignment - mmap_file/mmap_file_read_storage: null-check before close/unmap
JalinWang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.