Skip to content

fix(PROD-1504): surface container and template push failures in error summary #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5PK wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −4
Open

fix(PROD-1504): surface container and template push failures in error summary #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/lib/pushers/container-pusher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { getLoggerForGuid, state } from "core/state";
import { ContainerMapper } from "lib/mappers/container-mapper";
import { ModelMapper } from "lib/mappers/model-mapper";
import { Logs } from "core/logs";
import { FailureDetail, PusherResult } from "types/sourceData";

/**
* Container pusher with enhanced version-based comparison
Expand All @@ -12,7 +13,7 @@ import { Logs } from "core/logs";
export async function pushContainers(
sourceData: mgmtApi.Container[],
targetData: mgmtApi.Container[],
): Promise<{ status: "success" | "error"; successful: number; failed: number; skipped: number }> {
): Promise<PusherResult> {


// Extract data from sourceData - unified parameter pattern
Expand All @@ -30,6 +31,7 @@ export async function pushContainers(
let skipped = 0;
let processedCount = 0;
let overallStatus: "success" | "error" = "success";
const failureDetails: FailureDetail[] = [];

const containerMapper = new ContainerMapper(sourceGuid[0], targetGuid[0]);
const modelMapper = new ModelMapper(sourceGuid[0], targetGuid[0]);
Expand Down Expand Up @@ -140,6 +142,11 @@ export async function pushContainers(
failed++;
currentStatus = "error";
overallStatus = "error";
failureDetails.push({
name: sourceContainer.referenceName,
error: `Failed to update container "${sourceContainer.referenceName}" (ID: ${sourceContainer.contentViewID})`,
guid: sourceGuid[0],
});
}
}
}
Expand Down Expand Up @@ -169,6 +176,11 @@ export async function pushContainers(
failed++;
currentStatus = "error";
overallStatus = "error";
failureDetails.push({
name: sourceContainer.referenceName,
error: `Failed to create container "${sourceContainer.referenceName}"`,
guid: sourceGuid[0],
});
}
}
}
Expand All @@ -177,12 +189,17 @@ export async function pushContainers(
failed++;
currentStatus = "error";
overallStatus = "error";
failureDetails.push({
name: sourceContainer.referenceName,
error: error?.message || String(error),
guid: sourceGuid[0],
});
} finally {
processedCount++;
}
}

return { status: overallStatus, successful, failed, skipped };
return { status: overallStatus, successful, failed, skipped, failureDetails };
}

/**
Expand Down
11 changes: 9 additions & 2 deletions src/lib/pushers/template-pusher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { TemplateMapper } from "lib/mappers/template-mapper";
import { ModelMapper } from "lib/mappers/model-mapper";
import { ContainerMapper } from "lib/mappers/container-mapper";
import { ContentItemMapper } from "lib/mappers/content-item-mapper";
import { FailureDetail, PusherResult } from "types/sourceData";


/**
Expand All @@ -17,7 +18,7 @@ export async function pushTemplates(
targetData: any,
locale: string
// onProgress?: (processed: number, total: number, status?: 'success' | 'error') => void
): Promise<{ status: 'success' | 'error', successful: number, failed: number, skipped: number }> {
): Promise<PusherResult> {

// Extract data from sourceData - unified parameter pattern
const templates: mgmtApi.PageModel[] = sourceData || [];
Expand All @@ -37,6 +38,7 @@ export async function pushTemplates(
let processedCount = 0;
const totalTemplates = templates.length;
let overallStatus: 'success' | 'error' = 'success';
const failureDetails: FailureDetail[] = [];

for (let i = 0; i < templates.length; i++) {
let template = templates[i];
Expand Down Expand Up @@ -126,11 +128,16 @@ export async function pushTemplates(
failed++;
currentStatus = 'error';
overallStatus = 'error';
failureDetails.push({
name: template.pageTemplateName,
error: error?.message || String(error),
guid: sourceGuid[0],
});
}
}

processedCount++;
}

return { status: overallStatus, successful, failed, skipped }; // Return status object
return { status: overallStatus, successful, failed, skipped, failureDetails };
}
Loading