fix(PROD-1504): surface container and template push failures in error summary#148
Open
5PK wants to merge 1 commit into
Open
fix(PROD-1504): surface container and template push failures in error summary#1485PK wants to merge 1 commit into
5PK wants to merge 1 commit into
Conversation
… summary Container and template push failures were silently dropped from the final ERROR SUMMARY banner. Added `failureDetails` tracking to both `container-pusher.ts` and `template-pusher.ts`, returning a full `PusherResult` (including the new `failureDetails` array) so that per-item failures now appear in the error banner, consistent with how the model pusher already worked. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
failureDetailstracking tocontainer-pusher.tsandtemplate-pusher.tsso per-item failures now populate the error bannerPusherResulttype (includingfailureDetails), matching how the model pusher already workedDetails
The
pushContainersandpushTemplatesfunctions previously returned an inline object type without afailureDetailsfield. Failures were counted in thefailedcounter but the individual error messages were never collected, so the final ERROR SUMMARY banner had no detail lines for container or template failures.This fix:
FailureDetailandPusherResultfromtypes/sourceDatain both filesfailureDetails: FailureDetail[]array at the start of each push loopFailureDetailentry (name, error message, guid) for every failure path (update failure, create failure, and caught exception){ status, successful, failed, skipped, failureDetails }so the caller's error summary receives the full detail listJira: PROD-1504
Test plan
🤖 Generated with Claude Code