Skip to content

fix(PROD-1504): surface container and template push failures in error summary#148

Open
5PK wants to merge 1 commit into
mainfrom
fix/PROD-1504
Open

fix(PROD-1504): surface container and template push failures in error summary#148
5PK wants to merge 1 commit into
mainfrom
fix/PROD-1504

Conversation

@5PK
Copy link
Copy Markdown
Collaborator

@5PK 5PK commented May 28, 2026

Summary

  • Container and template push failures were silently dropped from the final ERROR SUMMARY banner
  • Added failureDetails tracking to container-pusher.ts and template-pusher.ts so per-item failures now populate the error banner
  • Both pushers now return the full PusherResult type (including failureDetails), matching how the model pusher already worked

Details

The pushContainers and pushTemplates functions previously returned an inline object type without a failureDetails field. Failures were counted in the failed counter but the individual error messages were never collected, so the final ERROR SUMMARY banner had no detail lines for container or template failures.

This fix:

  • Imports FailureDetail and PusherResult from types/sourceData in both files
  • Initialises a failureDetails: FailureDetail[] array at the start of each push loop
  • Pushes a FailureDetail entry (name, error message, guid) for every failure path (update failure, create failure, and caught exception)
  • Returns { status, successful, failed, skipped, failureDetails } so the caller's error summary receives the full detail list

Jira: PROD-1504

Test plan

  • Run a push that includes a container failure and confirm the ERROR SUMMARY banner lists the failing container by name
  • Run a push that includes a template failure and confirm the ERROR SUMMARY banner lists the failing template by name
  • Run a fully successful push and confirm no regressions in the summary output

🤖 Generated with Claude Code

… summary

Container and template push failures were silently dropped from the final
ERROR SUMMARY banner. Added `failureDetails` tracking to both
`container-pusher.ts` and `template-pusher.ts`, returning a full
`PusherResult` (including the new `failureDetails` array) so that per-item
failures now appear in the error banner, consistent with how the model
pusher already worked.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant