Repository navigation
fix: proxy MP4 GET and HEAD requests to AEM - #336
hannessolo wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Scope updated at the author request: this draft now contains only MP4 GET/HEAD routing to AEM and the associated proxy regression tests (adobe/da-live#1694). All HTML transformations, metadata fixes, block/cell normalization, and rendering-mode/site-config additions have been removed. HTML/rendering/config files are unchanged from the base branch. This draft no longer contains or claims the server-rendering portion of adobe/da-live#1695. The existing da-live rendering-mode fix is adobe/da-live#1704; related frontend drafts remain adobe/da-live#1725 and adobe/da-nx#992. Validation after narrowing: 551 tests and lint pass. Not deployed. |
Remove the HTML, metadata, rendering-mode, and site-config additions. Retain only MP4 GET/HEAD routing and its regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| import { UpstreamError } from '../utils/upstream.js'; | ||
|
|
||
| // for AEM we reuse the handleAEMProxyRequest for now as GETs are cheap here | ||
| // TODO refine and review for later for a full HEAD requests on AEM |
There was a problem hiding this comment.
@mhaack @andreituicu Do you have any context about why we decided to use GET requests in place of HEAD requests here? Is there anthing preventing us from doing so?
The agent correctly decided not to do that for mp4s (so you don't download a video when you do a HEAD) in https://github.com/adobe/da-universal/pull/336/changes#diff-6c4697efe25e416744b06d26ecbbce51f042b6c7aca87fcba6d724a6cb41be91R21, but it adds a special case - why don't we just always send actual HEAD requests?
Summary
MP4 routing only. Refs adobe/da-live#1688 and adobe/da-live#1694.
Scope
All additional HTML transformations, metadata normalization/precedence changes, empty-block/cell normalization, and rendering-mode/site-config changes have been removed from this draft. HTML/rendering/config files are unchanged from the base branch.
Related frontend drafts: adobe/da-live#1725 and adobe/da-nx#992.
Validation
npm test -- --reporter dot: 551 passing (full suite).npm run lint: passes; existing ESLint-env migration warnings remain.git diff --check: passes.Not deployed. Production-site MP4 playback validation remains pending.