Repository navigation
fix(quick-edit): honor rendering mode and clicked responsive targets - #992
hannessolo wants to merge 2 commits into
Conversation
Pass effective legacy section metadata options through initial and subsequent preview serialization. Refs adobe/da-live#1688 and adobe/da-live#1695. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Scope clarification: adobe/da-live#1704 already fixed rendering-mode selection and legacy section-metadata preservation in da-live Canvas/live previews. It explicitly excluded standalone previews and initial server-rendered HTML. This draft addresses the remaining standalone Quick Edit path: resolve the effective rendering options and forward them to the shared serializer instead of passing an ignored boolean. It does not repeat the da-live Canvas fix. Companion drafts: adobe/da-live#1725 handles remaining structured-value extraction and empty-cell/block serialization. At the author request, adobe/da-universal#336 now contains only MP4 GET/HEAD routing and regression tests; its added HTML, metadata, rendering-mode, and site-config changes have been removed. Production-site validation remains pending. |
Use the connected pending click target instead of the first matching source index, and avoid reusing an editor in another responsive clone. Preserve fallback behavior for stale or unrelated pending targets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Refs adobe/da-live#1688 and adobe/da-live#1695.
Summary
Validation
Test URLs:
The shared serializer improvements are in the corresponding da-live ewfixes PR.
Responsive clone editing
Additional validation: 48 on-demand editor and settlement browser tests pass, including three responsive regressions that failed before the fix. Targeted ESLint and
git diff --checkpass. The equivalent browser-local fix was also verified on the UPP marquee at 700, 1047, and 1440px: the clicked copy receives focus and returns to rendered MAS content on blur, without modifying authored content.Only the shared Quick Edit targeting fix is added here. The Milo-specific scoped-loader adapters and connected-DOM staging remain browser-local overrides and are not included in this PR.