Skip to content

fix(quick-edit): honor rendering mode and clicked responsive targets - #992

Draft
hannessolo wants to merge 2 commits into
mainfrom
ewfixes
Draft

hannessolo wants to merge 2 commits into
mainfrom
ewfixes

Conversation

@hannessolo

@hannessolo hannessolo commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Refs adobe/da-live#1688 and adobe/da-live#1695.

Summary

  • Resolve effective AEM rendering mode from explicit version or site creation date before standalone editor initialization.
  • Forward section-metadata preservation options through initial and subsequent preview serialization instead of passing an ignored boolean.
  • Preserve the existing fallback when configuration cannot be loaded.

Validation

  • 38 standalone portal browser tests passed, including rendering-version/date decisions, authenticated config requests, option forwarding and failure fallback.
  • Targeted ESLint, inline test-script lint and git diff --check passed.
  • Production-site behavior was not verified.

Test URLs:

The shared serializer improvements are in the corresponding da-live ewfixes PR.

Responsive clone editing

  • Fix Quick Edit opening an editor in a hidden or earlier responsive copy when several DOM elements share the same source index. Prefer the actual clicked element from the pending request.
  • Do not reuse an open editor belonging to another copy. Preserve the existing exact-index fallback for detached or unrelated pending targets.
  • Add five regression cases covering earlier visible/hidden copies, an editor already open in another copy, and detached/mismatched pending targets.

Additional validation: 48 on-demand editor and settlement browser tests pass, including three responsive regressions that failed before the fix. Targeted ESLint and git diff --check pass. The equivalent browser-local fix was also verified on the UPP marquee at 700, 1047, and 1440px: the clicked copy receives focus and returns to rendered MAS content on blur, without modifying authored content.

Only the shared Quick Edit targeting fix is added here. The Milo-specific scoped-loader adapters and connected-DOM staging remain browser-local overrides and are not included in this PR.

Pass effective legacy section metadata options through initial and subsequent preview serialization. Refs adobe/da-live#1688 and adobe/da-live#1695.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aem-code-sync

aem-code-sync Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@hannessolo

hannessolo commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor Author

Scope clarification: adobe/da-live#1704 already fixed rendering-mode selection and legacy section-metadata preservation in da-live Canvas/live previews. It explicitly excluded standalone previews and initial server-rendered HTML.

This draft addresses the remaining standalone Quick Edit path: resolve the effective rendering options and forward them to the shared serializer instead of passing an ignored boolean. It does not repeat the da-live Canvas fix.

Companion drafts: adobe/da-live#1725 handles remaining structured-value extraction and empty-cell/block serialization. At the author request, adobe/da-universal#336 now contains only MP4 GET/HEAD routing and regression tests; its added HTML, metadata, rendering-mode, and site-config changes have been removed. Production-site validation remains pending.

Use the connected pending click target instead of the first matching source index, and avoid reusing an editor in another responsive clone. Preserve fallback behavior for stale or unrelated pending targets.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hannessolo hannessolo changed the title fix(quick-edit): honor site rendering mode in standalone previews fix(quick-edit): honor rendering mode and clicked responsive targets Nov 13, 2026

This branch was successfully deployed

1 active deployment
ewfixes — f62885bb Deployed Nov 13, 2026 by aem-code-sync[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant