Skip to content

Twenty Nineteen sass adjustments - #14549

Open
sabernhardt wants to merge 6 commits into
WordPress:trunkfrom
sabernhardt:t19-sass-adjustments
Open

sabernhardt wants to merge 6 commits into
WordPress:trunkfrom
sabernhardt:t19-sass-adjustments

Conversation

@sabernhardt

Copy link
Copy Markdown

Co-authored by @rejaulalomkhan

  • Updates package-lock.json after npm audit fix and npm dedupe (which might be done with other npm updates anyway).
  • Changes the build to run each command sequentially, so npm run build does not need to be used twice to update the RTL stylesheet.
  • Introduces sass:string to prevent deprecation warnings for unquote() global built-in.
  • Uses math.div() to prevent deprecation warnings for slash-div calculations.
  • Does not replace @import (yet).

Trac 63013

Use of AI Tools

none by me


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sabernhardt

Copy link
Copy Markdown
Author

Replacing @import is not included in this PR because that is much more involved than the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant