Repository navigation
Twenty Nineteen sass adjustments, replacing import - #68
Draft
sabernhardt wants to merge 7 commits into
Draft
sabernhardt wants to merge 7 commits into
sabernhardt wants to merge 7 commits into
Conversation
sabernhardt
commented
Oct 20, 2026
| height: 2px; | ||
| } | ||
|
|
||
| @import "lists"; |
Owner
Author
There was a problem hiding this comment.
The _lists stylesheet is moved after _elements, placing the img, figure and blockquote rules before lists.
sabernhardt
commented
Oct 20, 2026
| .entry .entry-content .wp-block-image figcaption:lang(ar), | ||
| .entry .entry-content .wp-block-gallery .blocks-gallery-image figcaption:lang(ar), | ||
| .entry .entry-content .wp-block-gallery .blocks-gallery-item figcaption:lang(ar), .entry .entry-content .wp-block-cover-image .wp-block-cover-image-text:lang(ar), | ||
| .gallery-caption:lang(ar), .wp-caption-text:lang(ar), .entry .entry-content .wp-block-button .wp-block-button__link:lang(ar), .entry .entry-content .wp-block-archives li > a:lang(ar), |
Owner
Author
There was a problem hiding this comment.
The order of selectors is changed again, but the full list matches what is in trunk.
Selector with lang() |
T19 3.4 | Trunk (64597) | With Patch |
|---|---|---|---|
body |
1 | 76 | 72 |
button |
2 | 71 | 44 |
input |
3 | 72 | 73 |
select |
4 | 73 | 74 |
optgroup |
5 | 74 | 75 |
textarea |
6 | 75 | 76 |
.author-description .author-link |
7 | 47 | 47 |
.comment-metadata |
8 | 48 | 48 |
.comment-reply-link |
9 | 49 | 49 |
.comments-title |
10 | 50 | 50 |
.comment-author .fn |
11 | 51 | 51 |
.discussion-meta-info |
12 | 52 | 52 |
.entry-meta |
13 | 53 | 53 |
.entry-footer |
14 | 54 | 54 |
.main-navigation |
15 | 55 | 55 |
.no-comments |
16 | 56 | 56 |
.not-found .page-title |
17 | 77 | 77 |
.error-404 .page-title |
18 | 78 | 78 |
.post-navigation .post-title |
19 | 57 | 57 |
.page-links |
20 | 58 | 58 |
.page-description |
21 | 59 | 59 |
.pagination .nav-links |
22 | 60 | 60 |
.sticky-post |
23 | 61 | 61 |
.site-title |
24 | 62 | 62 |
.site-info |
25 | 63 | 63 |
#cancel-comment-reply-link |
26 | 64 | 64 |
h1 |
27 | 65 | 65 |
h2 |
28 | 66 | 66 |
h3 |
29 | 67 | 67 |
h4 |
30 | 68 | 68 |
h5 |
31 | 69 | 69 |
h6 |
32 | 70 | 70 |
.page-title |
33 | 46 | 71 |
blockquote cite |
34 | 45 | 46 |
table |
35 | 44 | 45 |
.button |
36 | 43 | 43 |
input[type=button] |
37 | 79 | 79 |
input[type=reset] |
38 | 80 | 80 |
input[type=submit] |
39 | 81 | 81 |
.comment-navigation .nav-previous |
40 | 41 | 41 |
.comment-navigation .nav-next |
41 | 42 | 42 |
.comment-list .pingback .comment-body |
42 | 39 | 35 |
.comment-list .trackback .comment-body |
43 | 40 | 36 |
.comment-list .pingback .comment-body .comment-edit-link |
44 | 37 | 37 |
.comment-list .trackback .comment-body .comment-edit-link |
45 | 38 | 38 |
.comment-form .comment-notes |
46 | 35 | 39 |
.comment-form label |
47 | 36 | 40 |
.widget_archive ul li |
48 | 27 | 25 |
.widget_categories ul li |
49 | 28 | 26 |
.widget_meta ul li |
50 | 29 | 27 |
.widget_nav_menu ul li |
51 | 30 | 28 |
.widget_pages ul li |
52 | 31 | 29 |
.widget_recent_comments ul li |
53 | 32 | 30 |
.widget_recent_entries ul li |
54 | 33 | 31 |
.widget_rss ul li |
55 | 34 | 32 |
.widget_tag_cloud .tagcloud |
56 | 26 | 33 |
.widget_calendar .calendar_wrap .wp-calendar-nav |
57 | 25 | 34 |
.entry .entry-content .wp-block-button .wp-block-button__link |
58 | 24 | 3 |
.entry .entry-content .wp-block-archives li > a |
59 | 21 | 4 |
.entry .entry-content .wp-block-categories li > a |
60 | 22 | 5 |
.entry .entry-content .wp-block-latest-posts li > a |
61 | 23 | 6 |
.entry .entry-content .wp-block-latest-posts .wp-block-latest-posts__post-date |
62 | 20 | 7 |
.entry .entry-content .wp-block-verse |
63 | 19 | 8 |
.entry .entry-content .has-drop-cap:not(:focus):first-letter |
64 | 18 | 9 |
.entry .entry-content .wp-block-pullquote cite |
65 | 17 | 10 |
.entry .entry-content .wp-block-cover-image .wp-block-cover-image-text |
66 | 11 | 11 |
.entry .entry-content .wp-block-cover-image .wp-block-cover-text |
67 | 12 | 12 |
.entry .entry-content .wp-block-cover-image h2 |
68 | 13 | 13 |
.entry .entry-content .wp-block-cover .wp-block-cover-image-text |
69 | 14 | 14 |
.entry .entry-content .wp-block-cover .wp-block-cover-text |
70 | 15 | 15 |
.entry .entry-content .wp-block-cover h2 |
71 | 16 | 16 |
.entry .entry-content .wp-block-audio figcaption |
72 | 6 | 17 |
.entry .entry-content .wp-block-video figcaption |
73 | 7 | 18 |
.entry .entry-content .wp-block-image figcaption |
74 | 8 | 19 |
.entry .entry-content .wp-block-gallery .blocks-gallery-image figcaption |
75 | 9 | 20 |
.entry .entry-content .wp-block-gallery .blocks-gallery-item figcaption |
76 | 10 | 21 |
.entry .entry-content .wp-block-file |
77 | 5 | 22 |
.entry .entry-content .wp-block-file .wp-block-file__button |
78 | 4 | 23 |
.entry .entry-content .wp-block-latest-comments .wp-block-latest-comments__comment-meta |
79 | 3 | 24 |
.wp-caption-text |
80 | 2 | 2 |
.gallery-caption |
81 | 1 | 1 |
sabernhardt
commented
Oct 20, 2026
| .wp-block-quote .wp-block-quote__citation:lang(ar), .wp-block-search .wp-block-search__button:lang(ar), .wp-block-button .wp-block-button__link:lang(ar), | ||
| .wp-block-cover .wp-block-cover-text:lang(ar), .wp-block-table:lang(ar), .wp-block-paragraph.has-drop-cap:lang(ar):not(:focus)::first-letter, .block-editor-default-block-appender textarea.block-editor-default-block-appender__content:lang(ar), .editor-post-title__block .editor-post-title__input:lang(ar), figcaption:lang(ar), | ||
| .gallery-caption:lang(ar), h1:lang(ar), | ||
| body:lang(ar), h1:lang(ar), |
Owner
Author
There was a problem hiding this comment.
The selectors match what is in trunk, but the order returns to how it was in the previous release except for the three selectors that needed to be added separately:
.wp-block-cover h2.wp-block[data-type="core/pullquote"][data-align=left] .wp-block-pullquote__citation.wp-block[data-type="core/pullquote"][data-align=right] .wp-block-pullquote__citation
Selector with lang() |
T19 3.4 | Trunk (64597) | With Patch |
|---|---|---|---|
body |
1 | 30 | 1 |
h1 |
2 | 24 | 2 |
h2 |
3 | 25 | 3 |
h3 |
4 | 26 | 4 |
h4 |
5 | 27 | 5 |
h5 |
6 | 28 | 6 |
h6 |
7 | 29 | 7 |
figcaption |
8 | 22 | 8 |
.gallery-caption |
9 | 23 | 9 |
.editor-post-title__block .editor-post-title__input |
10 | 21 | 10 |
.block-editor-default-block-appender textarea.block-editor-default-block-appender__content |
11 | 20 | 11 |
.wp-block-paragraph.has-drop-cap:not(:focus)::first-letter |
12 | 19 | 12 |
.wp-block-table |
13 | 18 | 13 |
.wp-block-cover h2 |
14 | 31 | 31 |
.wp-block-cover .wp-block-cover-text |
15 | 17 | 14 |
.wp-block-button .wp-block-button__link |
16 | 16 | 15 |
.wp-block-search .wp-block-search__button |
17 | 15 | 16 |
.wp-block-quote cite |
18 | 12 | 17 |
.wp-block-quote footer |
19 | 13 | 18 |
.wp-block-quote .wp-block-quote__citation |
20 | 14 | 19 |
.wp-block-pullquote[data-type="core/pullquote"] .wp-block-pullquote__citation |
21 | 10 | 20 |
.wp-block[data-type="core/pullquote"] .wp-block-pullquote__citation |
22 | 11 | 21 |
.wp-block[data-type="core/pullquote"][data-align=left] .wp-block-pullquote__citation |
23 | 32 | 32 |
.wp-block[data-type="core/pullquote"][data-align=right] .wp-block-pullquote__citation |
24 | 33 | 33 |
.wp-block-file |
25 | 9 | 22 |
ul.wp-block-archives li > a |
26 | 6 | 23 |
.wp-block-categories li > a |
27 | 7 | 24 |
.wp-block-latest-posts li > a |
28 | 8 | 25 |
.wp-block-latest-posts .wp-block-latest-posts__post-date |
29 | 5 | 26 |
.wp-block-latest-comments .wp-block-latest-comments__comment-meta |
30 | 4 | 27 |
.wp-caption dd |
31 | 3 | 28 |
.wp-block-freeform blockquote cite |
32 | 2 | 29 |
.wp-calendar-table |
33 | 1 | 30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 14549 plus edits to replace
@importThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.