Skip to content

test(server): isolate happy-path send from retry timing budget #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leemour merged 1 commit into from
Oct 17, 2026
+7 −5
Merged

test(server): isolate happy-path send from retry timing budget #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/server/server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,20 @@ const serve = async (
startedByCommand?: boolean
maxSubscriberBufferBytes?: number
maxSubscriberTotalBufferBytes?: number
requestTimeoutMs?: number
} = {},
) => {
const store = new SessionStore({ profile, keyring: memoryKeyring() })
store.writeToken("a-token")
const notes: string[] = []
const { requestTimeoutMs = 200, ...serverOptions } = extra
const server = new MaxServer({
store,
note: (line) => notes.push(line),
connection: (hooks) => new Connection({ ...hooks, live: true, createSocket: max.createSocket, timeoutMs: 200 }),
connection: (hooks) =>
new Connection({ ...hooks, live: true, createSocket: max.createSocket, timeoutMs: requestTimeoutMs }),
retryAfterMs: () => 0,
...extra,
...serverOptions,
})
running.push(server)
await server.start()
Expand Down Expand Up @@ -609,9 +612,8 @@ describe("a command through max serve", () => {
})

it("sends through the server too: one connection to MAX for everything", async () => {
const { store, max } = await serve("c-send")
// The reads after login first: sharing the 200 ms budget with them, the send timed out on CI and
// was retried with its cid — two MSG_SEND for one message.
// Coverage instrumentation can use the short retry fixtures' entire request budget.
const { store, max } = await serve("c-send", scripted(), { requestTimeoutMs: 2000 })
await tabReads(max)
const { client, opened } = commandClient(store)

Expand Down
Loading