Skip to content

REVIEW: list_documents recursive (#511) - #522

Open
rejojer wants to merge 2 commits into
review/base-9a8dd66from
feat/list-documents-recursive
Open

REVIEW: list_documents recursive (#511)#522
rejojer wants to merge 2 commits into
review/base-9a8dd66from
feat/list-documents-recursive

Conversation

@rejojer

@rejojer rejojer commented Sep 19, 2026

Copy link
Copy Markdown
Member

Review-only PR for #511. Do not merge.

@rejojer
list_documents: pass through the API's recursive flag
9cdab7b 
Listing a folder returned only its direct contents, with no way to
reach the documents in its sub-folders; the endpoint has taken
recursive all along, the SDK just never sent it. Listed documents also
carry a folder path, served by the cloud.

Local mode accepts the flag and ignores it — there are no folders to
descend into — and reports the same keys a cloud listing has, path
among them, always None.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-19T13:39:45.481172Z 9cdab7b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rejojer rejojer mentioned this pull request Sep 21, 2026
Closed
@rejojer
fix(sdk): list_documents review followups
b5ac06f 
- Forward recursive value instead of hardcoding True (#3)
- Raise limit cap from 100 to 10000 to match server (#4)
- Accept folder_id='root'/'' in local mode (#6)
- Fix wire test to assert presence not identity (#6, #9)
- Delete restating comments (#15)

Addresses PR #522 review findings 2-7.
@rejojer rejojer mentioned this pull request Sep 21, 2026
Merged
rejojer added a commit that referenced this pull request Sep 21, 2026
@rejojer
fix(sdk): list_documents review followups
ed06ec6 
- Forward recursive value instead of hardcoding True (#3)
- Raise limit cap from 100 to 10000 to match server (#4)
- Accept folder_id='root'/'' in local mode (#6)
- Fix wire test to assert presence not identity (#6, #9)
- Delete restating comments (#15)

Addresses PR #522 review findings 2-7.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rejojer