Skip to content

fix(sdk): list_documents review followups - #532

Closed
rejojer wants to merge 1 commit into
mainfrom
fix/list-documents-review-followups
Closed

rejojer wants to merge 1 commit into
mainfrom
fix/list-documents-review-followups

Conversation

@rejojer

@rejojer rejojer commented Sep 21, 2026

Copy link
Copy Markdown
Member

Addresses PR #522 review findings 2–7.

  • Forward recursive value instead of hardcoding True (string 'false' was silently inverted)
  • Raise client-side limit cap from 100 to 10000 (server changed four months ago)
  • Accept folder_id='root'/'' in local mode (matches agent_tools pattern)
  • Fix wire test to assert param presence, not identity
  • Delete restating comments

Review: #522

- Forward recursive value instead of hardcoding True (#3)
- Raise limit cap from 100 to 10000 to match server (#4)
- Accept folder_id='root'/'' in local mode (#6)
- Fix wire test to assert presence not identity (#6, #9)
- Delete restating comments (#15)

Addresses PR #522 review findings 2-7.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-21T08:28:21.723157Z 059aea0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rejojer rejojer closed this Sep 21, 2026
@rejojer
rejojer deleted the fix/list-documents-review-followups branch September 21, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant