Skip to content

fix: return the config of a from-patch request in its model-request - #2836

Open
larsbeck wants to merge 1 commit into
TimefoldAI:mainfrom
larsbeck:fix/from-patch-model-request
Open

larsbeck wants to merge 1 commit into
TimefoldAI:mainfrom
larsbeck:fix/from-patch-model-request

Conversation

@larsbeck

Copy link
Copy Markdown
Contributor

Fixes #2834.

Cause

DefaultSolverWorkerFacade.createPatchedDataset stored the unprocessed configuration of the parent for the new dataset, also when the from-patch request had its own config. The processed configuration came from the request. So GET /{id}/model-request of the new dataset showed the config of the parent, but the solve used the config of the request.

Change

When the patch request has a config, createPatchedDataset stores it as the unprocessed configuration too, as createDatasetInternal (from-input) does. A patch request without a config still takes both configurations from the parent.

Tests

Two new tests in DefaultSolverWorkerFacadeTest:

  • patchDataset_withConfiguration_returnsItAsTheModelRequestConfiguration: fails without the fix (the model request has the config of the parent), passes with it.
  • patchDataset_withoutConfiguration_keepsTheModelRequestConfigurationOfTheParent: passes before and after, and keeps the behavior without a config.

./mvnw clean install -pl service/worker -amd and ./mvnw verify --file service/test-model/pom.xml pass. I ran both with -Dquarkus.http.test-port=0, because another process used port 8081 on my machine.

The reproducer of #2834 uses config.run only, because a from-patch request with config.model.overrides answers 500 without #2833. #2835 (the name and the tags of the same dataset) is a separate fix.

A second-model review (Codex, 1 round) found no defects.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UUczJWM11RcvAp1qAfp4p4

createPatchedDataset stored the unprocessed configuration of the parent
for the new dataset, also when the patch request had its own config. So
model-request of the new dataset showed the config of the parent, but
the solve used the config of the request. Store the config of the
request as both, as from-input does. A patch request without a config
still takes both from the parent.

Fixes TimefoldAI#2834

Claude-Session: https://claude.ai/code/session_01UUczJWM11RcvAp1qAfp4p4
@larsbeck
larsbeck requested a review from a team November 17, 2026 13:49
Copilot AI balanced review requested due to automatic review settings November 17, 2026 13:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

This branch was successfully deployed

1 active deployment
internal — 156004ca Deployed Nov 17, 2026 by larsbeck via approval_required #5348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service SDK: model-request of a from-patch dataset shows the config of the parent, not of the request

2 participants