Repository navigation
Conversation
createPatchedDataset stored the unprocessed configuration of the parent for the new dataset, also when the patch request had its own config. So model-request of the new dataset showed the config of the parent, but the solve used the config of the request. Store the config of the request as both, as from-input does. A patch request without a config still takes both from the parent. Fixes TimefoldAI#2834 Claude-Session: https://claude.ai/code/session_01UUczJWM11RcvAp1qAfp4p4
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2834.
Cause
DefaultSolverWorkerFacade.createPatchedDatasetstored the unprocessed configuration of the parent for the new dataset, also when thefrom-patchrequest had its ownconfig. The processed configuration came from the request. SoGET /{id}/model-requestof the new dataset showed theconfigof the parent, but the solve used theconfigof the request.Change
When the patch request has a
config,createPatchedDatasetstores it as the unprocessed configuration too, ascreateDatasetInternal(from-input) does. A patch request without aconfigstill takes both configurations from the parent.Tests
Two new tests in
DefaultSolverWorkerFacadeTest:patchDataset_withConfiguration_returnsItAsTheModelRequestConfiguration: fails without the fix (the model request has theconfigof the parent), passes with it.patchDataset_withoutConfiguration_keepsTheModelRequestConfigurationOfTheParent: passes before and after, and keeps the behavior without aconfig../mvnw clean install -pl service/worker -amdand./mvnw verify --file service/test-model/pom.xmlpass. I ran both with-Dquarkus.http.test-port=0, because another process used port 8081 on my machine.The reproducer of #2834 uses
config.runonly, because afrom-patchrequest withconfig.model.overridesanswers 500 without #2833. #2835 (the name and the tags of the same dataset) is a separate fix.A second-model review (Codex, 1 round) found no defects.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UUczJWM11RcvAp1qAfp4p4