Repository navigation
Conversation
from-patch took the name of the new dataset only from the name query parameter, and ignored config.run.name and config.run.tags. So the dataset got a generated name and no tags, but its configuration had the run of the request. Read them as from-input does: the name query parameter wins over config.run.name. SolverWorkerFacade.patchDataset and patchAndSolveDataset get the tags, as createDataset does. Fixes TimefoldAI#2835 Claude-Session: https://claude.ai/code/session_01UUczJWM11RcvAp1qAfp4p4
The test model tests from-patch over REST, but CI builds it outside the main build, so its coverage does not count. AbstractModelAPIResourceTest calls fromPatch and fromInput with a recording SolverWorkerFacade. Claude-Session: https://claude.ai/code/session_01UUczJWM11RcvAp1qAfp4p4
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
triceo
removed their request for review
November 17, 2026 14:56
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2835.
Cause
AbstractModelAPIResource.fromPatchgave only thenamequery parameter toSolverWorkerFacade.patchDataset, andpatchDatasethad no parameter for the tags. Sofrom-patchignoredconfig.run.nameandconfig.run.tags: the new dataset got a generated name and no tags, but its configuration had therunof the request.Change
fromPatchreads the name and the tags fromconfig.run, asfromInputdoes: thenamequery parameter wins overconfig.run.name. Both endpoints use the same two private helpers now (runName,runTags).SolverWorkerFacade.patchDatasetandpatchAndSolveDatasetgetSet<String> tags, ascreateDatasethas.DefaultSolverWorkerFacadeputs the tags on the metadata of the new dataset.DefaultSolverWorkerFacadeis the only implementation, andAbstractModelAPIResourceis the only caller, also in timefold-solver-enterprise.POST /{resource}uses the opposite order: thereconfig.run.namewins over thenamequery parameter. This PR does not change that.Tests
EmployeeScheduleResourceTest.fromPatchTakesTheNameAndTagsOfTheRunConfiguration(REST, two cases: without and with thenamequery parameter): fails without the fix (a generated name, no tags), passes with it.AbstractModelAPIResourceTest(new, in the rest module): callsfromPatchandfromInputwith a recordingSolverWorkerFacade(ajava.lang.reflect.Proxy; the module has no Mockito). It is in the main build, so SonarCloud counts its coverage.DefaultSolverWorkerFacadeTest: the patch tests give tags and check them on the new dataset../mvnw clean install -pl service/definition,service/rest,service/worker -amdand./mvnw verify --file service/test-model/pom.xmlpass. I ran both with-Dquarkus.http.test-port=0, because another process used port 8081 on my machine.#2834 (the
model-requestof the same dataset) is a separate fix in #2836. Both changeDefaultSolverWorkerFacade.createPatchedDataset, in different lines.A second-model review (Codex, 2 rounds) found no defects.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UUczJWM11RcvAp1qAfp4p4