Conversation
…ers#3429) Some inlined functions had to be made non-inline for this to compile.
…ckers#3429) Move cell type-comparison predicates into `PathfindCell` as static methods and update `AIPathfind.cpp` zone and block calculations to use the class-scoped helpers.
Skyaero42
added
the
Refactor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. WalkthroughThe change adds Pathfinder constants, cell and pooled-info state, path nodes and route operations, bridge and wall layer handling, and zone calculation and lookup. It registers the Pathfinder headers and sources in the GameEngine build and includes compatibility-specific behavior under documented compile-time conditions. ChangesPathfinder implementation
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~60 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This change moves the pathfinder zone-management code into its own source file. No concrete defects were found in this update, so it appears ready to merge after normal build checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Skyaero42
force-pushed
the
skyaero/extract-pathfind-implementation
branch
from
October 5, 2026 18:32
fc7abbf to
673db51
Compare
Skyaero42
added a commit
to Skyaero42/GeneralsGameCode
that referenced
this pull request
Oct 5, 2026
Skyaero42
added a commit
to Skyaero42/GeneralsGameCode
that referenced
this pull request
Oct 5, 2026
Skyaero42
commented
Oct 5, 2026
| inline UnsignedShort getXIndex() const {return m_info->m_pos.x;} | ||
| inline UnsignedShort getYIndex() const {return m_info->m_pos.y;} | ||
|
|
||
| inline Bool isBlockedByAlly() const; |
Author
There was a problem hiding this comment.
Compiler didn't want to play nice with some of the functions being inlined, so it was removed.
Skyaero42
commented
Oct 5, 2026
| void setConnectLayer( PathfindLayerEnum layer ) { m_connectsToLayer = layer; } ///< set the cell layer connect id | ||
| PathfindLayerEnum getConnectLayer() const { return (PathfindLayerEnum)m_connectsToLayer; } ///< get the cell layer connect id | ||
|
|
||
| static Bool typesMatch(const PathfindCell& targetCell, const PathfindCell& sourceCell); |
Author
There was a problem hiding this comment.
These were global functions that better fit as a static function in the PathfindCell class
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
2b56a31b-122e-4e08-b863-f35a3f59cbc5
📒 Files selected for processing (16)
Core/GameEngine/CMakeLists.txtCore/GameEngine/Include/GameLogic/AIPathfind.hCore/GameEngine/Include/GameLogic/Pathfinder/PathfindCell.hCore/GameEngine/Include/GameLogic/Pathfinder/PathfindCellInfo.hCore/GameEngine/Include/GameLogic/Pathfinder/PathfindConstants.hCore/GameEngine/Include/GameLogic/Pathfinder/ZoneBlock.hCore/GameEngine/Source/GameLogic/AI/AIPathfind.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/Path.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/PathNode.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/PathfindCell.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/PathfindCellInfo.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/PathfindCellList.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/PathfindConstants.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/PathfindLayer.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/PathfindZoneManager.cppCore/GameEngine/Source/GameLogic/AI/Pathfinder/ZoneBlock.cpp
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Skyaero42
force-pushed
the
skyaero/extract-pathfind-implementation
branch
from
October 5, 2026 18:48
673db51 to
0912535
Compare
2 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts several pathfinder class implementations from the aipathfind.cpp source file into their own source files to increase readability and maintainability. This is another step into refactoring the pathfinding code.
Todo: