refactor(basetype): Make isInRegion consistent across Region types

[stephanmeesters]

• All four region types (IRegion2D, Region2D, IRegion3D, Region3D) now have the same isInRegion overloads: separate values, a point, and a whole region.
• Every check uses <=, so points on the edge count as inside.
• isInRegionNoZ is gone. The 3D types take a 2D point instead, and callers convert with asCoord2D(). Inlines completely.

AI was used.

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Refactors region boundary-check API across game logic.

The PR appears safe to merge; both earlier edge findings are addressed.

What we checked:

• Map checks might use height: No. asCoord2D() copies only x and y, and the selected Region3D overload checks only those values.

Summary

This PR gives the four region types matching isInRegion overloads and replaces isInRegionNoZ calls with 2D points. The latest change restores strict edge checks, addressing both earlier findings.

• Existing map checks keep their x/y behavior.
• Points on a region edge are excluded, contrary to the PR description.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Position["3D position"] --> Convert["asCoord2D()"]
  Convert --> Check["Region3D::isInRegion(Coord2D)"]
  Check --> Result["Strict x/y edge check"]

Loading

_{Reviews (2) · Last reviewed commit: "Revert from <= to <"}

[stephanmeesters]

Perhaps I'll add a set of isInRegionInclusive variants for the <= case

[xezon]

Makes sense for the current users. It is strange that they did not choose <= to begin with. It is especially apparent on floating points.

A difference of 0.0 means it is not inside, but 0.000001 means it is inside. But for integers that threshold is 1, which is much further away.

Having an inclusive one makes sense, because that covers the default use case for region inclusion checks. Imo the current isInRegion should be the exception, not the norm.