Skip to content

Add make_atan2 binding #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dance858 merged 2 commits into from
Oct 8, 2026
Merged

Add make_atan2 binding #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
673d0bf
Add make_atan2 binding for the engine's leaf-only atan2 atom
dance858 Oct 7, 2026
3eba08a
Bump SparseDiffEngine to 6612747 (atan2 atom, #133)
dance858 Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SparseDiffEngine
Open in desktop
Submodule SparseDiffEngine updated 16 files
+4 −0 include/atoms/bivariate_restricted_dom.h
+2 −1 include/atoms/elementwise_restricted_dom.h
+224 −0 src/atoms/bivariate_restricted_dom/atan2.c
+1 −1 src/atoms/bivariate_restricted_dom/quad_over_lin.c
+1 −1 src/atoms/bivariate_restricted_dom/rel_entr.c
+1 −0 src/atoms/elementwise_restricted_dom/atanh.c
+10 −0 src/atoms/elementwise_restricted_dom/common.c
+1 −0 src/atoms/elementwise_restricted_dom/entr.c
+1 −0 src/atoms/elementwise_restricted_dom/log.c
+1 −0 src/atoms/elementwise_restricted_dom/tan.c
+8 −0 tests/all_tests.c
+11 −17 tests/forward_pass/affine/test_sum.h
+6 −6 tests/forward_pass/composite/test_composite.h
+20 −0 tests/forward_pass/elementwise_restricted_dom/test_log.h
+70 −0 tests/jacobian_tests/bivariate_restricted_dom/test_atan2.h
+45 −0 tests/wsum_hess/bivariate_restricted_dom/test_atan2.h
35 changes: 35 additions & 0 deletions sparsediffpy/_bindings/atoms/atan2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#ifndef ATOM_ATAN2_H
#define ATOM_ATAN2_H

#include "bivariate_restricted_dom.h"
#include "common.h"

/* atan2(y, x), C argument order. Both arguments must be distinct variables of
the same shape; the engine returns NULL otherwise. */
static PyObject *py_make_atan2(PyObject *self, PyObject *args)
{
PyObject *y_capsule;
PyObject *x_capsule;
if (!PyArg_ParseTuple(args, "OO", &y_capsule, &x_capsule))
{
return NULL;
}
expr *y = (expr *) PyCapsule_GetPointer(y_capsule, EXPR_CAPSULE_NAME);
expr *x = (expr *) PyCapsule_GetPointer(x_capsule, EXPR_CAPSULE_NAME);
if (!y || !x)
{
PyErr_SetString(PyExc_ValueError, "invalid child capsule");
return NULL;
}

expr *node = new_atan2(y, x);
if (!node)
{
PyErr_SetString(PyExc_RuntimeError, "failed to create atan2 node");
return NULL;
}
expr_retain(node); /* Capsule owns a reference */
return PyCapsule_New(node, EXPR_CAPSULE_NAME, expr_capsule_destructor);
}

#endif /* ATOM_ATAN2_H */
3 changes: 3 additions & 0 deletions sparsediffpy/_bindings/bindings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "atoms/add.h"
#include "atoms/asinh.h"
#include "atoms/atan.h"
#include "atoms/atan2.h"
#include "atoms/atanh.h"
#include "atoms/broadcast.h"
#include "atoms/convolve.h"
Expand Down Expand Up @@ -121,6 +122,8 @@ static PyMethodDef DNLPMethods[] = {
{"make_tanh", py_make_tanh, METH_VARARGS, "Create tanh node"},
{"make_asinh", py_make_asinh, METH_VARARGS, "Create asinh node"},
{"make_atan", py_make_atan, METH_VARARGS, "Create atan node"},
{"make_atan2", py_make_atan2, METH_VARARGS,
"Create atan2 node: atan2(y, x), both arguments must be variables"},
{"make_atanh", py_make_atanh, METH_VARARGS, "Create atanh node"},
{"make_upper_tri", py_make_upper_tri, METH_VARARGS, "Create upper_tri node"},
{"make_broadcast", py_make_broadcast, METH_VARARGS, "Create broadcast node"},
Expand Down
Loading