Repository navigation
Add make_atan2 binding - #29
Merged
Merged
Conversation
atan2(y, x), C argument order, both arguments must be distinct variables of the same shape; a NULL from new_atan2 becomes a RuntimeError. Requires SparseDifferentiation/SparseDiffEngine#133; the submodule pointer is bumped once that lands on engine main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dance858
marked this pull request as ready for review
October 8, 2026 06:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C binding for the engine's leaf-only
atan2atom from SparseDifferentiation/SparseDiffEngine#133 (part of engine issue #130)._bindings/atoms/atan2.hparses two capsules and callsnew_atan2(y, x);bindings.cgets the include and themake_atan2method-table entry. ANULLfrom the engine (non-variable argument, repeated variable, shape mismatch) becomes aRuntimeError.The engine submodule is bumped to
6612747, which is enginemainafter #133.Verified locally: the extension builds and exports
make_atan2.Not included: the Python-level
sp.atan2wrapper, which lives onseparate-python-interface.🤖 Generated with Claude Code