[Implement] dispose manifest resource stream in GetSchemaFromResource; fixes #69

ReqIFSharp/ReqIFDeserializer.cs

@@ -164,7 +164,7 @@
 
                     return result;
                 }
                 catch (Exception ex) when (!(ex is OperationCanceledException))
                 {
                     this.logger.LogError(ex, "An error occurred while deserializing file {Path}", fileUri);
                     throw;
@@ -269,7 +269,7 @@
         /// <returns>
         /// Fully de-referenced <see cref="IEnumerable{ReqIF}"/> object graphs
         /// </returns>
         private IEnumerable<ReqIF> DeserializeReqIF(Stream stream, SupportedFileExtensionKind fileExtensionKind, bool validate = false, ValidationEventHandler validationEventHandler = null)
         {
             XmlReader xmlReader;
 
@@ -293,7 +293,7 @@
 
                         while (xmlReader.Read())
                         {
                             if ((xmlReader.NodeType == XmlNodeType.Element) && (xmlReader.Name == "REQ-IF"))
                             {
                                 var reqif = new ReqIF(this.loggerFactory);
                                 reqif.ReadXml(xmlReader);
@@ -301,7 +301,7 @@
                             }
                         }
 
                         this.logger.LogTrace("xml read in {Time}", sw.ElapsedMilliseconds);
                         sw.Stop();
 
                         return reqifs;
@@ -377,7 +377,7 @@
         /// <returns>
         /// Fully de-referenced <see cref="IEnumerable{ReqIF}"/> object graphs
         /// </returns>
         private async Task<IEnumerable<ReqIF>> DeserializeReqIFAsync(Stream stream, SupportedFileExtensionKind fileExtensionKind, CancellationToken token, bool validate = false, ValidationEventHandler validationEventHandler = null)
         {
             XmlReader xmlReader;
 
@@ -538,14 +538,15 @@
             var @namespace = type.Namespace;
             var reqifSchemaResourceName = $"{@namespace}.Resources.{resourceName}";
 
-            var stream = a.GetManifestResourceStream(reqifSchemaResourceName);
-
-            if (stream == null)
+            using (var stream = a.GetManifestResourceStream(reqifSchemaResourceName))
             {
-                throw new MissingManifestResourceException($"The {reqifSchemaResourceName} resource could not be found");
+                if (stream == null)
+                {
+                    throw new MissingManifestResourceException($"The {reqifSchemaResourceName} resource could not be found");
+                }
+
+                return XmlSchema.Read(stream, validationEventHandler);
             }
-
-            return XmlSchema.Read(stream, validationEventHandler);
         }
     }
 }