Skip to content

[Implement] dispose manifest resource stream in GetSchemaFromResource; fixes #69#75

Merged
samatstariongroup merged 1 commit into
developmentfrom
GH69
May 18, 2026
Merged

[Implement] dispose manifest resource stream in GetSchemaFromResource; fixes #69#75
samatstariongroup merged 1 commit into
developmentfrom
GH69

Conversation

@samatstariongroup
Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the ReqIFSharp code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

  • ReqIFSharp/ReqIFDeserializer.cs (GetSchemaFromResource) — the manifest resource stream from GetManifestResourceStream is now wrapped in a using block, so it's disposed on all paths. XmlSchema.Read fully materializes the schema into the returned XmlSchema before the stream is disposed, so behavior is unchanged. The null check (→ MissingManifestResourceException) is preserved inside the block

@sonarqubecloud
Copy link
Copy Markdown

@samatstariongroup samatstariongroup merged commit 0e869ce into development May 18, 2026
8 checks passed
@samatstariongroup samatstariongroup deleted the GH69 branch May 18, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants