Skip to content

fix(messaging): synchronize StreamingMessageHandler NetMQ socket sends #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tyagiquamar wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

fix(messaging): synchronize StreamingMessageHandler NetMQ socket sends #9810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Messaging/StreamingMessageHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public class StreamingMessageHandler : IMessagingHandler
private PushSocket _server;
private AlgorithmNodePacket _job;
private OrderEventJsonConverter _orderEventJsonConverter;
private readonly object _socketLock = new object();

/// <summary>
/// Gets or sets whether this messaging handler has any current subscribers.
Expand Down Expand Up @@ -100,7 +101,10 @@ public void Transmit(Packet packet)

message.Append(payload);

_server.SendMultipartMessage(message);
lock (_socketLock)
{
_server?.SendMultipartMessage(message);
}
}

/// <summary>
Expand All @@ -126,6 +130,11 @@ private void CheckPort()
/// </summary>
public void Dispose()
{
lock (_socketLock)
{
_server?.Dispose();
_server = null;
}
}
}
}