fix(messaging): synchronize StreamingMessageHandler NetMQ socket sends - #9810
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Synchronize NetMQ PushSocket sends and disposal in StreamingMessageHandler using a dedicated lock object (_socketLock).
Related Issue
Fixes #9790
Motivation and Context
StreamingMessageHandler.Transmit(Packet packet) sends packets over ZeroMQ via _server.SendMultipartMessage(message) on a NetMQ PushSocket. NetMQ sockets are not thread-safe. When multiple threads (such as algorithm execution and worker/result streaming threads) invoke Transmit or Send concurrently, concurrent NetMQ operations corrupt internal message buffers, crashing the process with NetMQException: Cannot close an uninitialised Msg.
Adding _socketLock synchronizes calls to _server?.SendMultipartMessage(message) and synchronizes resource clean-up during Dispose().
Requires Documentation Change
No
How Has This Been Tested?
Types of changes
Checklist: