Skip to content

fix(theme): keep the reveal circle on the toggle when zoomed #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorenzocorallo merged 1 commit into from
Oct 15, 2026
Merged

fix(theme): keep the reveal circle on the toggle when zoomed #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/components/shell/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,16 @@ function switchTheme(theme: Theme, source?: ThemeToggleSource) {
const current: Reveal = { from, to: theme, heading: theme, clip: null, hold: null }
reveal = current
const toggle = revealToggle(source)
const { x, y } = iconCenter(toggle) ?? { x: window.innerWidth / 2, y: window.innerHeight / 2 }
const radius = Math.hypot(Math.max(x, window.innerWidth - x), Math.max(y, window.innerHeight - y))
const width = window.innerWidth
const height = window.innerHeight
const { x, y } = iconCenter(toggle) ?? { x: width / 2, y: height / 2 }
const radius = Math.hypot(Math.max(x, width - x), Math.max(y, height - y))
const lightOn = theme === "light"
const bulb = (r: number) => `circle(${r}px at ${x}px ${y}px)`
// In percentages of the snapshot (the viewport), not px: under browser zoom Chrome scales px lengths on the
// transition pseudo-elements a second time, which moved the circle off the toggle. A circle's % radius is
// relative to the box's diagonal / √2.
const bulb = (r: number) =>
`circle(${(r / (Math.hypot(width, height) / Math.SQRT2)) * 100}% at ${(x / width) * 100}% ${(y / height) * 100}%)`
// The new snapshot is live: keep CSS transitions off until the reveal ends, or colors would also fade.
root.setAttribute("data-theme-switching", "")
root.setAttribute("data-theme-reveal", lightOn ? "on" : "off")
Expand Down
Loading