Repository navigation
fix(theme): keep the reveal circle on the toggle when zoomed - #99
Merged
Merged
Conversation
… toggle when zoomed With browser zoom, Chrome scales px lengths on the view-transition pseudo-elements again, so the circle's center drifted away from the toggle toward the middle of the screen. The center and radius are now percentages of the snapshot box, which zoom cannot distort.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With browser zoom, the light/dark reveal circle was centered away from the toggle: its center sat at roughly 0.62× the toggle's distance from the top-left, near the middle of the screen. Chrome applies zoom a second time to px lengths on the view-transition pseudo-elements, so
circle(r px at x px y px)no longer matchedgetBoundingClientRect.The clip now uses percentages of the snapshot box (the viewport): the center as
x / innerWidthandy / innerHeight, and the radius relative to the box's diagonal / √2, which is howcircle()resolves a % radius. Zoom doesn't affect these ratios.Verified in headless Chromium at 1× and 2× device pixels, with and without
zoom: 0.67on<html>: the circle's edge stays centered on the toggle. Before this change it drifted with zoom.pnpm check,typecheck,testandbuildpass.