Add regional form evolution details#1492
Conversation
…add_regional_form_evolution_details
…add_regional_form_evolution_details
|
@Naramsim can u check this PR, please? |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
Change description
This PR adds evolution details regarding all regional forms (Alola, Galar, Hisui, and Paldea) including some related region-specific evolutions (e.g. Cyndaquil to Quilava at level 17 instead of 14, but only in Hisui).
This is related to issue #1396. In addition to new evolution details,
region_idandbase_form_idare renamed to beregionandbase_formto be consistent with other fields (similar to PR #1487). Thebase_formfield was changed to aPokemonmodel so that regional forms could be specified. These fields were also missing from tests, so they were added as well.An unintended consequence of this is that the latest evolution detail will not necessarily reflect the current evolution (like the Cyndaquil example I gave previously). At some point I'd like to add something to make the current evolution method clearer (maybe even accessible by version group?) but while I tinker with that these additions should be added.
Contributor check list