fix: Rename region_id and base_form_id to region and base_form in evolution details#1487
Conversation
|
Looks like this PR includes contributions from your other PR regarding the main_generation field. Let's remove that from here to keep these separate |
317585d to
24b8ee9
Compare
…lution details For consistency with other fields (e.g. trade_species_id -> trade_species), evolution detail fields should omit the _id suffix. The serializer was manually naming them with _id, diverging from the documented API response. Fixes PokeAPI#1396
24b8ee9 to
4cdd1e8
Compare
Done, removed the main_generation changes — the PR now only includes the region/base_form rename. |
|
@jemarq04 some news on that PR? thank you |
|
Thanks again for catching this! I think to be fair, we should merge this PR and I will address the merge conflicts with my PR. (I shouldn't have waited two months to actually submit it of course lol) |
|
Ok let's merge this. Still we don't have any data for the two columns. |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
|
@Naramsim some tips for get data for this 2 columns? |
With this merged I'll fix the conflicts in my PR, but that should have all the data for these fields (#1492) |
For consistency with other fields (e.g. trade_species_id → trade_species), evolution detail fields should omit the _id suffix. Updated both the serializer and openapi.yml. Fixes #1396