Skip to content

fix: Rename region_id and base_form_id to region and base_form in evolution details#1487

Merged
Naramsim merged 1 commit intoPokeAPI:masterfrom
santichausis:fix/evolution-chain-region-base-form
Apr 19, 2026
Merged

fix: Rename region_id and base_form_id to region and base_form in evolution details#1487
Naramsim merged 1 commit intoPokeAPI:masterfrom
santichausis:fix/evolution-chain-region-base-form

Conversation

@santichausis
Copy link
Copy Markdown
Contributor

For consistency with other fields (e.g. trade_species_id → trade_species), evolution detail fields should omit the _id suffix. Updated both the serializer and openapi.yml. Fixes #1396

@jemarq04
Copy link
Copy Markdown
Member

Looks like this PR includes contributions from your other PR regarding the main_generation field. Let's remove that from here to keep these separate

…lution details

For consistency with other fields (e.g. trade_species_id -> trade_species),
evolution detail fields should omit the _id suffix. The serializer was
manually naming them with _id, diverging from the documented API response.

Fixes PokeAPI#1396
@santichausis santichausis force-pushed the fix/evolution-chain-region-base-form branch from 24b8ee9 to 4cdd1e8 Compare April 14, 2026 13:34
@santichausis
Copy link
Copy Markdown
Contributor Author

Looks like this PR includes contributions from your other PR regarding the main_generation field. Let's remove that from here to keep these separate

Done, removed the main_generation changes — the PR now only includes the region/base_form rename.

@daniilmastrangeli
Copy link
Copy Markdown

@jemarq04 some news on that PR? thank you

@jemarq04
Copy link
Copy Markdown
Member

Thanks again for catching this! I think to be fair, we should merge this PR and I will address the merge conflicts with my PR. (I shouldn't have waited two months to actually submit it of course lol)

@Naramsim
Copy link
Copy Markdown
Member

Ok let's merge this. Still we don't have any data for the two columns.

@Naramsim Naramsim merged commit 4070d63 into PokeAPI:master Apr 19, 2026
9 checks passed
@pokeapi-machine-user
Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link
Copy Markdown

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

@daniilmastrangeli
Copy link
Copy Markdown

@Naramsim some tips for get data for this 2 columns?

@jemarq04
Copy link
Copy Markdown
Member

jemarq04 commented Apr 19, 2026

Ok let's merge this. Still we don't have any data for the two columns.

With this merged I'll fix the conflicts in my PR, but that should have all the data for these fields (#1492)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document: EvolutionChain.region and EvolutionChain.base_form does not exist

5 participants