Skip to content

fix(leaderboard): render empty search state with clear filter button #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
O2sa merged 1 commit into from
Oct 17, 2026
Merged

fix(leaderboard): render empty search state with clear filter button #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 99 additions & 76 deletions src/features/leaderboard/components/leaderboard-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { AlertTriangle, ExternalLink, ArrowUpDown, ArrowUp, ArrowDown } from "lu
import { Avatar } from "@/components/layout/avatar";
import { Tooltip, TooltipContent, TooltipTrigger } from "@/components/ui/tooltip";
import { Card, CardContent, CardHeader, CardTitle, CardDescription } from "@/components/ui/card";
import { Button } from "@/components/ui/button";
import { useTranslation } from "@/components/providers/language-provider";
import { cn } from "@/utils/cn";
import type { ScoredLeaderboardEntry as LeaderboardEntry } from "../types";
Expand Down Expand Up @@ -266,86 +267,108 @@ export function LeaderboardTable({
</tr>
</thead>
<tbody>
{filtered.map((user) => (
<tr
key={user.username}
className={cn(
"border-b border-border/50 transition-colors hover:bg-muted/30",
user.impactRank <= 3 && "bg-primary/5",
)}
>
<td className="px-3 py-3">
<span
className={cn(
"inline-flex h-8 w-8 items-center justify-center rounded-full text-xs font-bold",
user.impactRank === 1
? "bg-amber-100 text-amber-800 dark:bg-amber-900/40 dark:text-amber-300"
: user.impactRank === 2
? "bg-slate-100 text-slate-700 dark:bg-slate-800 dark:text-slate-300"
: user.impactRank === 3
? "bg-orange-100 text-orange-800 dark:bg-orange-900/40 dark:text-orange-300"
: "bg-muted text-muted-foreground",
)}
>
{user.impactRank}
</span>
{filtered.length === 0 && search.trim() ? (
<tr>
<td colSpan={6} className="px-6 py-12 text-center text-muted-foreground">
<div className="flex flex-col items-center justify-center gap-2">
<p>
{t("leaderboard.noDevelopersSearch", {
query: search,
})}
</p>
<Button
type="button"
variant="secondary"
size="sm"
onClick={() => setSearch("")}
>
{t("leaderboard.clearSearch")}
</Button>
</div>
</td>
<td className="px-3 py-3">
{(() => {
const profileUrl = (
countrySlug
? `/user/${user.username}?country=${encodeURIComponent(countrySlug)}`
: `/user/${user.username}`
) as Route;
</tr>
) : (
filtered.map((user) => (
<tr
key={user.username}
className={cn(
"border-b border-border/50 transition-colors hover:bg-muted/30",
user.impactRank <= 3 && "bg-primary/5",
)}
>
<td className="px-3 py-3">
<span
className={cn(
"inline-flex h-8 w-8 items-center justify-center rounded-full text-xs font-bold",
user.impactRank === 1
? "bg-amber-100 text-amber-800 dark:bg-amber-900/40 dark:text-amber-300"
: user.impactRank === 2
? "bg-slate-100 text-slate-700 dark:bg-slate-800 dark:text-slate-300"
: user.impactRank === 3
? "bg-orange-100 text-orange-800 dark:bg-orange-900/40 dark:text-orange-300"
: "bg-muted text-muted-foreground",
)}
>
{user.impactRank}
</span>
</td>
<td className="px-3 py-3">
{(() => {
const profileUrl = (
countrySlug
? `/user/${user.username}?country=${encodeURIComponent(countrySlug)}`
: `/user/${user.username}`
) as Route;

return (
<div className="flex items-center gap-2">
<Link href={profileUrl}>
<Avatar
src={user.avatarUrl}
alt={user.name || user.username}
size={32}
className="transition-transform hover:scale-105"
/>
</Link>
<div className="min-w-0">
<div className="flex items-center gap-1.5">
<Link
href={profileUrl}
className="truncate font-semibold text-primary hover:underline"
>
{user.name || user.username}
</Link>
<a
href={getGithubProfileUrl(user.username)}
target="_blank"
rel="noopener noreferrer"
className="inline-flex items-center text-muted-foreground transition-colors hover:text-foreground"
aria-label={t("a11y.openProfile", {
name: user.name || user.username,
})}
>
<ExternalLink className="h-3 w-3" />
</a>
return (
<div className="flex items-center gap-2">
<Link href={profileUrl}>
<Avatar
src={user.avatarUrl}
alt={user.name || user.username}
size={32}
className="transition-transform hover:scale-105"
/>
</Link>
<div className="min-w-0">
<div className="flex items-center gap-1.5">
<Link
href={profileUrl}
className="truncate font-semibold text-primary hover:underline"
>
{user.name || user.username}
</Link>
<a
href={getGithubProfileUrl(user.username)}
target="_blank"
rel="noopener noreferrer"
className="inline-flex items-center text-muted-foreground transition-colors hover:text-foreground"
aria-label={t("a11y.openProfile", {
name: user.name || user.username,
})}
>
<ExternalLink className="h-3 w-3" />
</a>
</div>
<p className="truncate text-xs text-muted-foreground">
@{user.username}
</p>
</div>
<p className="truncate text-xs text-muted-foreground">
@{user.username}
</p>
</div>
</div>
);
})()}
</td>
<td className="px-3 py-3 text-start">
<span className="font-bold text-primary">{user.finalScore}</span>
</td>
<td className="px-3 py-3 text-start font-mono text-xs">{user.repoScore}</td>
<td className="px-3 py-3 text-start font-mono text-xs">{user.prScore}</td>
<td className="px-3 py-3 text-start font-mono text-xs">
{user.contributionScore}
</td>
</tr>
))}
);
})()}
</td>
<td className="px-3 py-3 text-start">
<span className="font-bold text-primary">{user.finalScore}</span>
</td>
<td className="px-3 py-3 text-start font-mono text-xs">{user.repoScore}</td>
<td className="px-3 py-3 text-start font-mono text-xs">{user.prScore}</td>
<td className="px-3 py-3 text-start font-mono text-xs">
{user.contributionScore}
</td>
</tr>
))
)}
</tbody>
</table>
</div>
Expand Down
66 changes: 64 additions & 2 deletions src/features/leaderboard/tests/leaderboard-table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,36 @@
// Mock translations
vi.mock("@/components/providers/language-provider", () => ({
useTranslation: () => ({
t: (key: string) => {
t: (key: string, params?: Record<string, string | number>) => {
const translations: Record<string, string> = {
"leaderboard.title": "Leaderboard",
"leaderboard.description": "Leaderboard description",
"leaderboard.developer": "Developer",
"leaderboard.impactRank": "Impact Rank",
"leaderboard.search": "Search",
"leaderboard.partialErrors": "Partial Errors",
"leaderboard.noDevelopersSearch": 'No developers found matching "{query}".',
"leaderboard.clearSearch": "Clear search",
"comparison.final.score": "Final Score",
"comparison.repo.score": "Repo Score",
"comparison.pr.score": "PR Score",
"comparison.contribution.score": "Contribution Score",
"a11y.openProfile": "Open profile",
};

return translations[key] ?? key;
const template = translations[key] ?? key;
if (!params) return template;
return Object.keys(params).reduce(
(acc, k) => acc.split(`{${k}}`).join(String(params[k])),
template,
);
},
}),
}));

// Mock Avatar
vi.mock("@/components/layout/avatar", () => ({
Avatar: ({ src, alt }: { src: string; alt: string }) => <img src={src} alt={alt} />,

Check warning on line 49 in src/features/leaderboard/tests/leaderboard-table.test.tsx

View workflow job for this annotation

GitHub Actions / Validate (Node 24.x) 

Using `<img>` could result in slower LCP and higher bandwidth. Consider using `<Image />` from `next/image` or a custom image loader to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element
}));

// Mock Tooltip components
Expand Down Expand Up @@ -277,3 +284,58 @@
expect(document.activeElement).not.toBe(search);
});
});

describe("LeaderboardTable empty search state", () => {
afterEach(() => {
cleanup();
});

const users = [
{
username: "alice",
name: "Alice",
avatarUrl: "https://example.com/alice.png",
impactRank: 1,
finalScore: 80,
repoScore: 30,
prScore: 20,
contributionScore: 40,
},
];

const renderLeaderboard = () =>
render(
<LeaderboardTable
users={users}
failedUsers={[]}
title="Global"
totalFromSource={1}
usersProcessed={1}
/>,
);

test("shows empty search state when query matches no developers", async () => {
const user = userEvent.setup();
renderLeaderboard();

const searchInput = screen.getByPlaceholderText("Search");
await user.type(searchInput, "nonexistent");

expect(screen.getByText('No developers found matching "nonexistent".')).toBeDefined();
expect(screen.getByRole("button", { name: /clear search/i })).toBeDefined();
});

test("clicking clear search resets the search input and restores developers", async () => {
const user = userEvent.setup();
renderLeaderboard();

const searchInput = screen.getByPlaceholderText("Search") as HTMLInputElement;
await user.type(searchInput, "nonexistent");

const clearButton = screen.getByRole("button", { name: /clear search/i });
await user.click(clearButton);

expect(searchInput.value).toBe("");
expect(screen.getByText("Alice")).toBeDefined();
});
});
2 changes: 2 additions & 0 deletions src/locales/ar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@
"leaderboard.empty.title": "لم يتم العثور على دول",
"leaderboard.empty.description": "ستظهر الدول المتاحة هنا.",
"leaderboard.noCountriesSearch": "لا توجد دول تطابق بحثك.",
"leaderboard.noDevelopersSearch": "لم يتم العثور على مطورين يطابقون \"{query}\".",
"leaderboard.clearSearch": "مسح البحث",
"leaderboard.noDevelopersFor": "لم يتم حساب قائمة المتصدرين في هذه الدولة بعد.",
"leaderboard.error.retry": "حاول مرة أخرى",
"leaderboard.viewCountry": "عرض لوحة المتصدرين",
Expand Down
2 changes: 2 additions & 0 deletions src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@
"leaderboard.empty.title": "No countries found",
"leaderboard.empty.description": "Available countries will appear here.",
"leaderboard.noCountriesSearch": "No countries match your search.",
"leaderboard.noDevelopersSearch": "No developers found matching \"{query}\".",
"leaderboard.clearSearch": "Clear search",
"leaderboard.noDevelopersFor": "No leaderboard has been calculated for this country yet.",
"leaderboard.error.retry": "Try again",
"leaderboard.viewCountry": "View leaderboard",
Expand Down
Loading