Repository navigation
fix(leaderboard): render empty search state with clear filter button - #251
Merged
Merged
Conversation
|
@Sanjaykris20 is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
O2sa
approved these changes
Oct 17, 2026
Owner
|
🎊 Welcome, @Sanjaykris20! Your first contribution has been merged! 🚀 Thank you for helping improve the project! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving! |
Owner
|
Fixes #250 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user searches for a developer name that doesn't match anyone in the leaderboard, the table body renders completely blank. The table headers remain visible but there is no feedback — the UI looks broken.
Solution
When
filtered.length === 0 && search.trim()is truthy, render a full-width empty state row inside<tbody>that:leaderboard.noDevelopersSearch(interpolated with{query})setSearch("")to reset the filter instantlyFiles changed
src/features/leaderboard/components/leaderboard-table.tsx<tbody>src/locales/en.jsonleaderboard.noDevelopersSearchandleaderboard.clearSearchsrc/locales/ar.jsonChecklist
colSpan={6})t("leaderboard.noDevelopersSearch", { query })for i18nsetSearch("")en.jsonandar.jsontranslation files updatedFixes #250