Skip to content

Remove unused CustomClassHolder bases from Userbuffers wrappers #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksivaman merged 2 commits into from
Oct 23, 2026
Merged

Remove unused CustomClassHolder bases from Userbuffers wrappers #3732

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27f8ec5
Remove unused CustomClassHolder bases from userbuffers wrappers
pggPL Oct 22, 2026
3d92bc3
Merge branch 'main' into remove_custom_class_holder
ksivaman Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions transformer_engine/pytorch/csrc/extensions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,7 @@ void newton_schulz(int64_t ctx_ptr, int64_t m, int64_t n, at::Tensor x, int64_t
* Comm+GEMM Overlap Wrappers
**************************************************************************************************/

class CommOverlapHelper : torch::CustomClassHolder {
class CommOverlapHelper {
public:
// Shared ownership of an ncclComm_t. The deleter calls ncclCommDestroy when
// the last reference (held by the helper and/or any CommOverlap consumers)
Expand Down Expand Up @@ -873,7 +873,7 @@ class CommOverlapHelper : torch::CustomClassHolder {
NcclCommSharedPtr get_nccl_comm(std::string comm_name);
};

class CommOverlap : torch::CustomClassHolder, public transformer_engine::CommOverlapBase {
class CommOverlap : public transformer_engine::CommOverlapBase {
private:
// Keeps the cuBLASMp NCCL communicator alive for the lifetime of this
// instance, independent of the CommOverlapHelper that created it.
Expand Down Expand Up @@ -913,7 +913,7 @@ class CommOverlap : torch::CustomClassHolder, public transformer_engine::CommOve

}; // CommOverlap

class CommOverlapP2P : torch::CustomClassHolder, public transformer_engine::CommOverlapP2PBase {
class CommOverlapP2P : public transformer_engine::CommOverlapP2PBase {
private:
// Keeps the cuBLASMp NCCL communicator alive for the lifetime of this
// instance, independent of the CommOverlapHelper that created it.
Expand Down
Loading