Repository navigation
Remove unused CustomClassHolder bases from Userbuffers wrappers - #3732
Merged
Merged
Conversation
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Contributor
[Medium impact] The PR appears safe to merge. SummaryRemoves
Reviews (2) · Last reviewed commit: "Merge branch 'main' into remove_custom_c..." · Reviewed by Greptile |
Member
|
/te-ci pytorch L1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove unused
torch::CustomClassHolderinheritance from the three C++ Userbuffers wrappers:CommOverlapHelper,CommOverlap, andCommOverlapP2P.These classes are exposed through pybind11, with
std::shared_ptrholders for the overlap classes. They are not registered as TorchBind classes and do not use the intrusive-pointer functionality supplied byCustomClassHolder. Removing the bases eliminates an unnecessary PyTorch dependency; the existing TE base classes and pybind11 bindings are retained.Type of change
Changes
torch::CustomClassHolderbases intransformer_engine/pytorch/csrc/extensions.h.Validation
2.15.0a0+875d815502, CUDA 13.4. Reused the previously built common CUDA library; MPI, cuBLASMp, NVSHMEM and NCCL EP disabled.CPP_ONLY=1), license check andgit diff --checkpassed.Multi-GPU communication/GEMM overlap, optional backends, and the full L0 runtime suite were not run. This is not a complete stable-ABI migration. C++ consumers must rebuild against the updated class declarations.
Checklist