Repository navigation
refactor(ci): extract release qualification and serialize Codex reviews #4419
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,239 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name: Release Qualification | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| release-tag: | ||
| description: Release tag identifying the candidate | ||
| required: true | ||
| type: string | ||
| source-sha: | ||
| description: Source commit of the candidate artifacts in the calling run | ||
| required: true | ||
| type: string | ||
| is-prerelease: | ||
| description: Whether the candidate is a pre-release | ||
| required: true | ||
| type: boolean | ||
| outputs: | ||
| artifact-name: | ||
| description: Artifact containing the qualification result | ||
| value: ${{ jobs.qualification-result.outputs.artifact-name }} | ||
| current-profile-passed: | ||
| description: Whether every required qualification suite passed | ||
| value: ${{ jobs.qualification-result.outputs.current-profile-passed }} | ||
| secrets: | ||
| CODEX_SECURITY_API_KEY: | ||
| required: true | ||
| CACHIX_AUTH_TOKEN: | ||
| required: false | ||
|
|
||
| permissions: | ||
| contents: read | ||
| packages: read | ||
|
|
||
| env: | ||
| RELEASE_TAG: ${{ inputs.release-tag }} | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| security: | ||
| name: Security Scan | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| packages: read | ||
| security-events: write | ||
| uses: ./.github/workflows/security-scan.yml | ||
| with: | ||
| candidate_ref: ${{ inputs.release-tag }} | ||
| fail-on-codex-findings: true | ||
| fail-on-static-findings: false | ||
| images: | | ||
| ghcr.io/nvidia/openshell/gateway:${{ inputs.source-sha }} | ||
| ghcr.io/nvidia/openshell/sandbox:${{ inputs.source-sha }} | ||
| ghcr.io/nvidia/openshell/supervisor:${{ inputs.source-sha }} | ||
| secrets: | ||
| CODEX_SECURITY_API_KEY: ${{ secrets.CODEX_SECURITY_API_KEY }} | ||
| CACHIX_AUTH_TOKEN: ${{ secrets.CACHIX_AUTH_TOKEN }} | ||
|
|
||
| prepare-integration: | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| packages: read | ||
| uses: ./.github/workflows/prepare-integration-inputs.yml | ||
| with: | ||
| source-sha: ${{ inputs.source-sha }} | ||
| deb-artifact-name: deb-linux-amd64 | ||
| rpm-artifact-name: rpm-linux-x86_64 | ||
|
|
||
| conformance-integration: | ||
| needs: prepare-integration | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| packages: read | ||
| uses: ./.github/workflows/integration-runner.yml | ||
| with: | ||
| category: conformance | ||
| source-sha: ${{ needs.prepare-integration.outputs.source_sha }} | ||
| integration-inputs-artifact-id: ${{ needs.prepare-integration.outputs.integration_inputs_artifact_id }} | ||
| test-matrix: >- | ||
| [ | ||
| {"environment":"ubuntu-docker-rootful","installer":"deb","testsuite":"conformance"}, | ||
| {"environment":"ubuntu-k3s","installer":"k3s","testsuite":"conformance"}, | ||
| {"environment":"fedora-podman-rootful","installer":"rpm","testsuite":"conformance"}, | ||
| {"environment":"fedora-podman-rootless","installer":"rpm","testsuite":"conformance"} | ||
| ] | ||
|
|
||
| feature-specific-integration: | ||
| needs: prepare-integration | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| packages: read | ||
| uses: ./.github/workflows/integration-runner.yml | ||
| with: | ||
| category: feature-specific | ||
| source-sha: ${{ needs.prepare-integration.outputs.source_sha }} | ||
| integration-inputs-artifact-id: ${{ needs.prepare-integration.outputs.integration_inputs_artifact_id }} | ||
| test-matrix: >- | ||
| [ | ||
| {"environment":"fedora-podman-rootful","installer":"rpm","testsuite":"provider-refresh"}, | ||
| {"environment":"fedora-podman-rootless","installer":"rpm","testsuite":"provider-refresh"} | ||
| ] | ||
|
|
||
| docker-e2e: | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| packages: read | ||
| uses: ./.github/workflows/e2e-docker-test.yml | ||
| with: | ||
| image-tag: ${{ inputs.source-sha }} | ||
| checkout-ref: ${{ inputs.source-sha }} | ||
| runner: linux-arm64-cpu8 | ||
| conformance-artifact-prefix: openshell-conformance | ||
|
|
||
| vm-e2e: | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| packages: read | ||
| uses: ./.github/workflows/e2e-vm-test.yml | ||
| with: | ||
| checkout-ref: ${{ inputs.source-sha }} | ||
| conformance-artifact-prefix: openshell-conformance | ||
|
|
||
| protobuf-compatibility: | ||
| name: Protobuf Compatibility | ||
| runs-on: linux-amd64-cpu8 | ||
| timeout-minutes: 15 | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| ref: ${{ inputs.source-sha }} | ||
|
|
||
| - uses: ./.github/actions/check-protobuf-compatibility | ||
| with: | ||
| ref: refs/tags/${{ env.RELEASE_TAG }} | ||
|
|
||
| compatibility-review: | ||
| name: Compatibility Review (advisory) | ||
| permissions: | ||
| contents: read | ||
| uses: ./.github/workflows/codex-compatibility.yml | ||
| with: | ||
| candidate_ref: ${{ inputs.release-tag }} | ||
| source_sha: ${{ inputs.source-sha }} | ||
| secrets: | ||
| CODEX_SECURITY_API_KEY: ${{ secrets.CODEX_SECURITY_API_KEY }} | ||
|
|
||
| qualification-result: | ||
| name: Release Qualification | ||
| if: always() | ||
| needs: | ||
| - protobuf-compatibility | ||
| - security | ||
| - conformance-integration | ||
| - feature-specific-integration | ||
| - docker-e2e | ||
| - vm-e2e | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| permissions: | ||
| contents: read | ||
| outputs: | ||
| artifact-name: ${{ steps.summary.outputs.artifact-name }} | ||
| current-profile-passed: ${{ steps.summary.outputs.current-profile-passed }} | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
| ref: ${{ inputs.source-sha }} | ||
|
|
||
| - name: Record qualification result | ||
| id: summary | ||
| env: | ||
| CONFORMANCE_RESULT: ${{ needs.conformance-integration.result }} | ||
| DOCKER_E2E_RESULT: ${{ needs.docker-e2e.result }} | ||
| FEATURE_INTEGRATION_RESULT: ${{ needs.feature-specific-integration.result }} | ||
| IS_PRERELEASE: ${{ inputs.is-prerelease }} | ||
| PROTO_COMPATIBILITY_RESULT: ${{ needs.protobuf-compatibility.result }} | ||
| SECURITY_RESULT: ${{ needs.security.result }} | ||
| SOURCE_SHA: ${{ inputs.source-sha }} | ||
| VM_E2E_RESULT: ${{ needs.vm-e2e.result }} | ||
| run: | | ||
| set -euo pipefail | ||
| current_profile_passed=$(tasks/scripts/generate-qualification-summary.sh qualification-summary.json) | ||
| artifact_name="qualification-${RELEASE_TAG}-run-${GITHUB_RUN_ID}-attempt-${GITHUB_RUN_ATTEMPT}" | ||
| run_url=$(jq -r '.run.url' qualification-summary.json) | ||
|
|
||
| { | ||
| echo "artifact-name=${artifact_name}" | ||
| echo "current-profile-passed=${current_profile_passed}" | ||
| } >> "${GITHUB_OUTPUT}" | ||
|
|
||
| { | ||
| echo "## Release qualification" | ||
| echo | ||
| echo "- Candidate: \`${RELEASE_TAG}\` (\`${SOURCE_SHA}\`)" | ||
| echo "- Current qualification profile passed: **${current_profile_passed}**" | ||
| echo "- RFC-0014 qualification coverage complete: **false**" | ||
| echo "- Run: [${GITHUB_RUN_ID}, attempt ${GITHUB_RUN_ATTEMPT}](${run_url})" | ||
| echo | ||
| echo "| Suite | Result |" | ||
| echo "| --- | --- |" | ||
| echo "| Protobuf API compatibility | ${PROTO_COMPATIBILITY_RESULT} |" | ||
| echo "| Security | ${SECURITY_RESULT} |" | ||
| echo "| Conformance integration | ${CONFORMANCE_RESULT} |" | ||
| echo "| Feature integration | ${FEATURE_INTEGRATION_RESULT} |" | ||
| echo "| Docker E2E | ${DOCKER_E2E_RESULT} |" | ||
| echo "| VM E2E | ${VM_E2E_RESULT} |" | ||
| echo | ||
| echo "Advisory compatibility findings do not affect the qualification result." | ||
| echo "See the Compatibility Review job and compatibility-review-run-${GITHUB_RUN_ID}-attempt-${GITHUB_RUN_ATTEMPT} artifact in [this run](${run_url})." | ||
| } >> "${GITHUB_STEP_SUMMARY}" | ||
|
|
||
| - name: Upload qualification result | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 | ||
| with: | ||
| name: ${{ steps.summary.outputs.artifact-name }} | ||
| path: qualification-summary.json | ||
| retention-days: 90 | ||
| if-no-files-found: error | ||
|
|
||
| - name: Require current qualification profile before publication | ||
| if: steps.summary.outputs.current-profile-passed != 'true' | ||
| run: | | ||
| echo "Release ${RELEASE_TAG} did not pass the current release-tag-v1 qualification profile." >&2 | ||
| exit 1 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.