Repository navigation
Conversation
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-4419.docs.buildwithfern.com/openshell |
elezar
left a comment
There was a problem hiding this comment.
The qualification extraction looks reasonable. Please make the shared Codex concurrency group retain pending reviews before merging: cancel-in-progress: false protects running work but still allows newer reviews to cancel pending ones. I also left a non-blocking suggestion about whether the advisory compatibility review needs to wait for the entire Security Scan workflow.
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
|
/ok-to-test 7988c45 |
elezar
left a comment
There was a problem hiding this comment.
Failed prerequisite builds now lose qualification evidence (.github/workflows/release-tag.yml:133-135).
Before this PR, when a Debian, RPM, VM-driver, or image build failed, the top-level qualification-result job still ran through if: always(), recorded unsuccessful or skipped suites, and uploaded the qualification summary. With this PR, the caller depends on all those builds and has no condition overriding the implicit success check, so any prerequisite failure skips the entire reusable workflow. The internal if: always() summary job cannot run when its caller is skipped. Maintainers therefore lose the qualification report for failed candidates, and checks that could have run independently are also skipped.
Please preserve qualification summary generation when prerequisite builds fail, while continuing to block publication. This needs failure handling at the caller boundary; the condition on the summary job inside the called workflow is insufficient.
Reviewed at 7988c45ff0532d4f0760b091daf9b6f4bf683e5d. Qualification-summary tests and git diff --check passed; live release scheduling was not tested.
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
|
/ok-to-test f05c4ed |
elezar
left a comment
There was a problem hiding this comment.
Reviewed f05c4ed. The caller condition addresses the previously reported loss of qualification evidence after prerequisite build failures. No remaining actionable findings. Branch Checks, Actionlint, and Zizmor pass; live release failure handling remains untested.
Summary
Move tagged-release qualification into a callable workflow so its security, compatibility, and behavioral checks can be reviewed separately from publication. The two Codex reviews are scheduled independently and share a concurrency group that retains pending reviews while preventing overlapping API use across release and manual runs.
Related Issue
No tracking issue, at maintainer request. This is the first PR in the release-workflow stack. #4420 is stacked on this branch and adds separate Release and Pre-release orchestration. Merge this PR first, then retarget #4420 to
main.Changes
release-qualification.yml.queue: maxto retain up to 100 pending reviews. Either review can run first; compatibility does not wait for the other security scanners. Its findings and execution failures remain advisory, and the caller waits for it to finish.Testing
concurrency.queuediagnostic. Unfiltered actionlint 1.7.12 reports two expected findings for GitHub's supportedqueue: maxsetting; see Actionlint does not know aboutqueue:key for concurrency rhysd/actionlint#657. Repository lint configuration is unchanged.git diff --checkpasses.Checklist