Skip to content

update accvlab perf#36

Open
xupinjie wants to merge 1 commit into
NVIDIA:mainfrom
xupinjie:pinjie/perf_report_ut
Open

update accvlab perf#36
xupinjie wants to merge 1 commit into
NVIDIA:mainfrom
xupinjie:pinjie/perf_report_ut

Conversation

@xupinjie

Copy link
Copy Markdown
Collaborator

Description

Update video decoder performance

Type of Change

Please select (at least one):

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation / examples / tutorials / demos
  • Supporting functionality change (fix or feature in documentation generation, helper scripts, ...)
  • Refactoring / internal change
  • Other (please describe):

Testing

Checklist for testing:

  • Tests added or updated if/as needed
  • Repository test runner executed: scripts/run_tests.sh

Optionally, add a brief description.

Documentation, Examples, Tutorials, Demos

Checklist for documentation:

  • User-facing documentation updated if/as needed (including API docs)
  • Examples / tutorials / demos updated or added (if relevant)
  • Limitations and constraints documented (if relevant)
  • Performance documented (if relevant)
  • Documentation building successful & checks outlined in the Documentation Checks section of the Contribution Guide are performed

Optionally, add a brief description.

Code Quality

Checklist for dependencies:

  • Dependencies updated in the relevant pyproject.toml if/as needed
  • Code formatted according to the Code Formatting Guide

Optionally, add a brief description.

Related Issues / Context

If applicable, link related issues, discussions etc.


DCO / Sign-Off

Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.

References

For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):

Please also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.

@xupinjie xupinjie requested a review from RmSchaffert June 15, 2026 07:22
@xupinjie

Copy link
Copy Markdown
Collaborator Author

/build

@xupinjie

Copy link
Copy Markdown
Collaborator Author

Compare the impact of different hardware on decoding performance.
all_decoders_hevc_gop30

@xupinjie

Copy link
Copy Markdown
Collaborator Author

Compare the impact of GOP size on decoding performance.

accvlab_fps_vs_gop_hw

@RmSchaffert RmSchaffert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added some in-line comments. Please have a look.

Comment thread packages/on_demand_video_decoder/docs/evaluation.rst Outdated
Comment thread packages/on_demand_video_decoder/docs/evaluation.rst Outdated
Comment thread packages/on_demand_video_decoder/docs/evaluation.rst
@RmSchaffert

Copy link
Copy Markdown
Collaborator

Should we add the plots to the evaluation page?

@xupinjie

Copy link
Copy Markdown
Collaborator Author

Should we add the plots to the evaluation page?

The performance data may still change, and I’m concerned that once binary image files are added to Git, they’ll be difficult to replace later. Perhaps a good approach would be to use some scripts embedded in the documentation to generate the plots online.

Signed-off-by: pinjie <pinjiex@nvidia.com>
@xupinjie xupinjie force-pushed the pinjie/perf_report_ut branch from 472eec3 to 4a2a68e Compare June 18, 2026 06:16
@xupinjie

Copy link
Copy Markdown
Collaborator Author

/build

@RmSchaffert

Copy link
Copy Markdown
Collaborator

The performance data may still change, and I’m concerned that once binary image files are added to Git, they’ll be difficult to replace later. Perhaps a good approach would be to use some scripts embedded in the documentation to generate the plots online.

Good point. As the results are also presented as a table in the docu, I think we could also add the plots later.
Let me also revise the plots in PR #29.

@RmSchaffert

Copy link
Copy Markdown
Collaborator

/build

@RmSchaffert RmSchaffert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the in-line comments

- 595

On-demand Video Decoder - Across Video Configurations and Hardware
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the underscore length

- Library / Version
- Backend
* - ``accvlab_gpu``
- NVDEC

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please still add some info (e.g. accv_lab.on_demand_video_decoder) to the Library / Version column of the accvlab_gpu row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants