Added polyline interpolation (in the new lane_helpers sub-package)#29
Open
RmSchaffert wants to merge 1 commit into
Open
Added polyline interpolation (in the new lane_helpers sub-package)#29RmSchaffert wants to merge 1 commit into
lane_helpers sub-package)#29RmSchaffert wants to merge 1 commit into
Conversation
Collaborator
Author
|
/build |
RmSchaffert
force-pushed
the
lane_helpers_polyline
branch
from
f5f64ed to
c78240b
Compare
Collaborator
Author
|
/build |
Signed-off-by: Roman Schaffert <rschaffert@nvidia.com>
RmSchaffert
force-pushed
the
lane_helpers_polyline
branch
from
c78240b to
b04b055
Compare
Collaborator
Author
|
/build |
1 similar comment
Collaborator
Author
|
/build |
xupinjie
requested changes
Jun 18, 2026
Comment on lines
+23
to
+26
| if (err != cudaSuccess) { \ | ||
| fprintf(stderr, "CUDA error: '%s' in '%s' at line %d\n Description: %s\n", \ | ||
| cudaGetErrorName(err), __FILE__, __LINE__, cudaGetErrorString(err)); \ | ||
| exit(err); \ |
Collaborator
There was a problem hiding this comment.
Exiting directly is dangerous. The caller should catch the exception in Python.
Comment on lines
+32
to
+35
| if (err != cudaSuccess) { \ | ||
| fprintf(stderr, "CUDA error: '%s' in '%s' at line %d\n Description: %s\n", \ | ||
| cudaGetErrorName(err), __FILE__, __LINE__, cudaGetErrorString(err)); \ | ||
| exit(err); \ |
Comment on lines
+47
to
+66
| AT_ASSERTM(tensor.is_cpu() || tensor.is_cuda(), description, " must be on CPU or CUDA"); | ||
| } | ||
|
|
||
| inline void check_contiguous(const at::Tensor& tensor, const char* description) { | ||
| AT_ASSERTM(tensor.is_contiguous(), description, " must be contiguous"); | ||
| } | ||
|
|
||
| inline void check_type(const at::Tensor& tensor, const char* description) { | ||
| if (tensor.is_cuda()) { | ||
| AT_ASSERTM(tensor.scalar_type() == torch::kFloat32 || tensor.scalar_type() == torch::kFloat64 || | ||
| tensor.scalar_type() == torch::kFloat16 || tensor.scalar_type() == torch::kBFloat16, | ||
| description, " must have dtype float16, float32, float64, or bfloat16 on CUDA"); | ||
| } else { | ||
| AT_ASSERTM(tensor.scalar_type() == torch::kFloat32 || tensor.scalar_type() == torch::kFloat64, | ||
| description, " must have dtype float32 or float64 on CPU"); | ||
| } | ||
| } | ||
|
|
||
| inline void check_same_device(const at::Tensor& lhs, const at::Tensor& rhs, const char* message) { | ||
| AT_ASSERTM(lhs.device() == rhs.device(), message); |
Collaborator
There was a problem hiding this comment.
pytorch/pytorch#20287
AT_ASSERTM looks like a error usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new
lane_helperspackage with polyline interpolation as the first contained functionalityType of Change
Please select (at least one):
Testing
Checklist for testing:
scripts/run_tests.shOptionally, add a brief description.
Documentation, Examples, Tutorials, Demos
Checklist for documentation:
Optionally, add a brief description.
Code Quality
Checklist for dependencies:
pyproject.tomlif/as neededOptionally, add a brief description.
Related Issues / Context
If applicable, link related issues, discussions etc.
DCO / Sign-Off
Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.
References
For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):
docs/guides/CONTRIBUTION_GUIDE.mddocs/guides/DEVELOPMENT_GUIDE.mddocs/guides/DOCUMENTATION_SETUP_GUIDE.mddocs/guides/FORMATTING_GUIDE.mdPlease also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.