Skip to content

feature: Groundwork for USB capture as a Picture service source #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewowi merged 3 commits into from
Oct 19, 2026
Merged

feature: Groundwork for USB capture as a Picture service source #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b208549
feat: USB capture as a Picture service source, behind a platform seam
Gohnnyman Oct 19, 2026
e8027ad
USB capture: race-free stand-in, a frame wait apart from the decode
ewowi Oct 19, 2026
41fcaea
USB capture: read the picture count under the lock
ewowi Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions docs/help/help.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3733,13 +3733,16 @@
"controls": {
"source": {
"line": "Where the picture comes from.",
"more": "The test pattern is a test card in the layout of Philips' PM5544, drawn at any size."
"more": "The test pattern is a test card in the layout of Philips' PM5544, drawn at any size. **usb capture** decodes MJPEG from an HDMI grabber, scaled to fit."
},
"fps": {
"line": "Frames a second asked of a capture device, which streams the nearest rate it offers."
},
"width": {
"line": "The picture's width in pixels."
"line": "The picture's width in pixels, and the most a capture scales its frames to."
},
"height": {
"line": "The picture's height in pixels."
"line": "The picture's height in pixels, under the same ceiling as the width."
}
},
"role": "service",
Expand Down
18 changes: 10 additions & 8 deletions docs/reference/metrics/code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Code

Generated by [`moondeck/check/check_code.py`](../../../moondeck/check/check_code.py) on every run. **Do not edit by hand.**

Every function, block and file over a limit the [coding standards](../../contributing/coding-standards.md#static-checks) set. Current state only: the trend is this file's git history. The list only shrinks, per rule and in total, and a touched file clears its own rows.

**1610 finding(s)** across 320 file(s). 2.57% of all lines are duplicated, 3586 lines.
**1611 finding(s)** across 322 file(s). 2.40% of all lines are duplicated, 3345 lines.

## By rule

Expand All @@ -19,7 +19,7 @@
| long parameter list | 35 |
| large stack frame | 33 |
| raw allocation in light | 28 |
| large file | 25 |
| large file | 26 |
| name spread | 22 |

## How a finding is solved
Expand All @@ -44,10 +44,10 @@

| Area | Findings |
|---|---:|
| `test` | 558 |
| `test` | 557 |
| `light` | 402 |
| `core` | 364 |
| `platform` | 174 |
| `platform` | 176 |
| `ui` | 81 |
| `moondeck` | 22 |
| `src` | 7 |
Expand Down Expand Up @@ -157,7 +157,6 @@
| `test/unit/light/unit_FireEffect.cpp` | 5 | `lines 29-42, also in test/unit/light/unit_RainbowEffect.cpp:69`, duplicated block 14 |
| `test/unit/light/unit_FreqSawsEffect.cpp` | 5 | `lines 19-29, also in test/unit/light/unit_RainbowEffect.cpp:69`, duplicated block 11 |
| `test/unit/light/unit_GEQ3DEffect.cpp` | 5 | `lines 58-75, also in test/unit/light/unit_PaintBrushEffect.cpp:44`, duplicated block 18 |
| `test/unit/light/unit_MoonLiveScripts.cpp` | 5 | `lines 292-300, also in test/unit/light/unit_MoonLiveScripts.cpp:264`, duplicated block 9 |
| `test/unit/light/unit_RandomEffect.cpp` | 5 | `lines 10-22, also in test/unit/light/unit_RandomMapModifier.cpp:115`, duplicated block 13 |
| `src/core/module/Scheduler.cpp` | 4 | `Scheduler::getControlWide`, complex function 18 |
| `src/core/moonlive/MoonLive.cpp` | 4 | `moonlive::MoonLive::ensureArena`, complex function 21 |
Expand All @@ -183,6 +182,7 @@
| `test/unit/light/unit_FixedRectangleEffect.cpp` | 4 | `lines 90-103, also in test/unit/light/unit_SolidEffect.cpp:9`, duplicated block 14 |
| `test/unit/light/unit_Layer_extrude.cpp` | 4 | `lines 155-168, also in test/unit/light/unit_Layer_extrude.cpp:124`, duplicated block 14 |
| `test/unit/light/unit_Layer_live_modifier.cpp` | 4 | `lines 96-105, also in test/unit/light/unit_RainbowEffect.cpp:69`, duplicated block 10 |
| `test/unit/light/unit_MoonLiveScripts.cpp` | 4 | `lines 292-300, also in test/unit/light/unit_MoonLiveScripts.cpp:264`, duplicated block 9 |
| `test/unit/light/unit_NetworkSendDriver_no_alloc_in_loop.cpp` | 4 | `lines 49-59, also in test/unit/light/unit_NetworkSendDriver_no_alloc_in_loop.cpp:18`, duplicated block 11 |
| `test/unit/light/unit_NetworkSendDriver_packet.cpp` | 4 | `lines 346-354, also in test/unit/light/unit_NetworkSendDriver_packet.cpp:292`, duplicated block 9 |
| `test/unit/light/unit_ParallelSlots.cpp` | 4 | `lines 522-532, also in test/unit/light/unit_ParallelSlots.cpp:493`, duplicated block 11 |
Expand All @@ -204,10 +204,10 @@
| `src/module_types.cpp` | 3 | `registerModuleTypes`, long function 153 |
| `src/platform/desktop/moonlive_asm_arm64.cpp` | 3 | `lines 34-39, also in src/platform/esp32/moonlive_asm_riscv.cpp:33`, duplicated block 6 |
| `src/platform/esp32/moonlive_asm_xtensa.cpp` | 3 | `lines 482-488, also in src/platform/esp32/moonlive_asm_riscv.cpp:296`, duplicated block 7 |
| `src/platform/teensy/platform_teensy.cpp` | 3 | `platform::resolveHostStep`, complex function 16 |
| `src/platform/teensy/platform_teensy_ota.cpp` | 3 | `platform::otaWriteStream`, complex function 16 |
| `test/unit/core/unit_NetworkModule_ethernet.cpp` | 3 | `lines 276-285, also in test/unit/core/unit_NetworkModule_ethernet.cpp:193`, duplicated block 10 |
| `test/unit/light/unit_AuroraEffect.cpp` | 3 | `lines 40-48, also in test/unit/light/unit_PolarLut_equivalence.cpp:40`, duplicated block 9 |
| `test/unit/light/unit_MoonLiveLayout.cpp` | 3 | `lines 685-935, also in test/unit/light/unit_MoonLiveLayout.cpp:403`, duplicated block 251 |
| `test/unit/light/unit_PolarLut_equivalence.cpp` | 3 | `lines 40-55, also in test/unit/light/unit_NoiseEffect.cpp:33`, duplicated block 16 |
| `test/unit/light/unit_PongEffect.cpp` | 3 | `lines 80-91, also in test/unit/light/unit_PongEffect.cpp:10`, duplicated block 12 |
| `test/unit/light/unit_RmtLedDriver_lifecycle.cpp` | 3 | `lines 19-30, also in test/unit/light/unit_RmtLedDriver_pins.cpp:17`, duplicated block 12 |
Expand Down Expand Up @@ -254,7 +254,6 @@
| `src/platform/esp32/moonlive_asm_riscv.h` | 2 | `lines 70-87, also in src/platform/esp32/moonlive_asm_xtensa.h:74`, duplicated block 18 |
| `src/platform/esp32/moonlive_emit_riscv.cpp` | 2 | `lines 51-56, also in src/platform/esp32/moonlive_emit_riscv.cpp:24`, duplicated block 6 |
| `src/platform/teensy/moonlive_asm_thumb2.cpp` | 2 | `lines 66-71, also in src/platform/esp32/moonlive_asm_xtensa.cpp:189`, duplicated block 6 |
| `src/platform/teensy/platform_teensy.cpp` | 2 | `platform::resolveHostStep`, complex function 16 |
| `test/js/ui-midi-bridge.test.mjs` | 2 | `lines 4-16, also in test/js/ui-gamepad-bridge.test.mjs:4`, duplicated block 13 |
| `test/unit/core/unit_AudioService_sync.cpp` | 2 | `lines 313-322, also in test/unit/core/unit_AudioService_sync.cpp:269`, duplicated block 10 |
| `test/unit/core/unit_DevicesModule_hue.cpp` | 2 | `lines 63-69, also in test/unit/core/unit_DevicesModule_hue.cpp:42`, duplicated block 7 |
Expand All @@ -274,6 +273,7 @@
| `test/unit/light/unit_MoonLiveScriptResolve.cpp` | 2 | `lines 90-97, also in test/unit/light/unit_MoonLiveScriptResolve.cpp:78`, duplicated block 8 |
| `test/unit/light/unit_NetworkReceiveEffect_protocols.cpp` | 2 | `lines 23-44, also in test/unit/light/unit_NetworkReceiveEffect.cpp:23`, duplicated block 22 |
| `test/unit/light/unit_NoiseEffect.cpp` | 2 | `lines 33-48, also in test/unit/light/unit_PolarLut_equivalence.cpp:40`, duplicated block 16 |
| `test/unit/light/unit_PictureEffect.cpp` | 2 | `lines 218-226, also in test/unit/light/unit_PictureEffect.cpp:205`, duplicated block 9 |
| `test/unit/light/unit_Scroll.cpp` | 2 | `lines 6-20, also in test/unit/light/unit_Splat.cpp:6`, duplicated block 15 |
| `test/unit/light/unit_SineEffect.cpp` | 2 | `lines 22-30, also in test/unit/light/unit_DistortionWavesEffect.cpp:26`, duplicated block 9 |
| `test/unit/light/unit_SingleColumnLayout.cpp` | 2 | `lines 12-25, also in test/unit/light/unit_GridLayout.cpp:8`, duplicated block 14 |
Expand Down Expand Up @@ -346,7 +346,8 @@
| `src/platform/esp32/platform_esp32_sdmmc.cpp` | 1 | `platform::mountCard`, complex function 13 |
| `src/platform/esp32/platform_esp32_tasks.cpp` | 1 | `platform::taskSnapshot`, complex function 12 |
| `src/platform/esp32/platform_esp32_usb_midi.cpp` | 1 | `lines 253-259, also in src/platform/teensy/platform_teensy.cpp:767`, duplicated block 7 |
| `src/platform/platform.h` | 1 | `platform.h`, large file 1448 |
| `src/platform/esp32/platform_esp32_usbvideo.cpp` | 1 | `lines 10-17, also in src/platform/teensy/platform_teensy.cpp:774`, duplicated block 8 |
| `src/platform/platform.h` | 1 | `platform.h`, large file 1492 |
| `src/platform/teensy/platform_teensy_gpio_dma.cpp` | 1 | `lines 310-315, also in src/platform/esp32/platform_esp32_parlio.cpp:286`, duplicated block 6 |
| `src/platform/teensy/platform_teensy_improv.cpp` | 1 | `platform::improvProvisioningInit`, long parameter list 9 |
| `src/ui/install-picker.js` | 1 | `install-picker.js`, large file 1048 |
Expand All @@ -372,6 +373,7 @@
| `test/unit/light/unit_GridLayout.cpp` | 1 | `lines 8-21, also in test/unit/light/unit_SingleColumnLayout.cpp:12`, duplicated block 14 |
| `test/unit/light/unit_Layer_persistence.cpp` | 1 | `lines 45-51, also in test/unit/light/unit_TextEffect.cpp:18`, duplicated block 7 |
| `test/unit/light/unit_Layer_phase_animation.cpp` | 1 | `lines 77-85, also in test/unit/light/unit_RandomMapModifier.cpp:115`, duplicated block 9 |
| `test/unit/light/unit_MoonLiveLayout.cpp` | 1 | `unit_MoonLiveLayout.cpp`, large file 1113 |
| `test/unit/light/unit_NetworkReceiveEffect.cpp` | 1 | `lines 23-44, also in test/unit/light/unit_NetworkReceiveEffect_protocols.cpp:23`, duplicated block 22 |
| `test/unit/light/unit_ParallelLedDriver_doublebuffer.cpp` | 1 | `lines 93-104, also in test/unit/light/unit_ParallelLedDriver_pinexpander.cpp:94`, duplicated block 12 |
| `test/unit/light/unit_Rings241Layout.cpp` | 1 | `lines 18-30, also in test/unit/light/unit_SingleColumnLayout.cpp:19`, duplicated block 13 |
Expand Down
1 change: 1 addition & 0 deletions esp32/main/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ idf_component_register(
"../../src/platform/esp32/platform_esp32_i2c.cpp"
"../../src/platform/esp32/platform_esp32_ir.cpp"
"../../src/platform/esp32/platform_esp32_usb_midi.cpp"
"../../src/platform/esp32/platform_esp32_usbvideo.cpp"
"../../src/platform/esp32/platform_esp32_es8311.cpp"
INCLUDE_DIRS
"../../src"
Expand Down
Loading
Loading