Repository navigation
Let Core own installation distribution - #584
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core now selects each node Provider’s pinned Runtime release from its own matched installation distribution. Deployment POST/PUT reject browser-supplied
runtime; installation facts supply the installer checksum and available releases used by Web commands. The existing Core catalog also serves node downloads, so Web’s duplicate distribution loader, routes, setting and Runtime inputs are removed.The catalog derives identities from Provider declarations, binds metadata to Core’s source revision, and rechecks artifact availability when reading installation facts or selecting a deployment. Native installers, retained release downloads, checksums, path isolation, Range/HEAD responses, pinned HTTPS redirects and same-release offline completion remain supported. Compose mounts node payloads read-only in Core. Contracts, generated clients, consumers and English/Chinese documentation change together.
Validation: 3,190 Go tests passed; the 21 SDK/operator prerequisites were supplied and their cases passed. Four real Docker fixture tests require an unavailable image. Client 805, Web 373, 32 browser scenarios, Python 134 and Compose configuration 4 passed; Python skipped root-only helper transfer and unavailable keyctl. Build/vet, generated-contract freshness, website and translations passed. Local Compose smoke could not fetch its pinned Web base image because gcr.io DNS failed; CI subsequently passed that smoke and every other required check. Final same-revision live Core/E2B/microsandbox qualification is tracked by the cutover integration lane.
Independent fresh review found no substantiated in-scope issues. After rebasing onto the latest cutover, the patch is identical; 111 focused Go/database tests and 207 client tests, typecheck, build/vet and OpenAPI freshness passed.